Fix copy/paste error in IPPermissionSet.Ungroup#250
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Sep 3, 2021
Merged
Fix copy/paste error in IPPermissionSet.Ungroup#250k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
release-note-none
Contributor
|
Thanks for this. I figured we should add a test for this so I've opened #265. Probably should add to the same PR but this will do. |
Contributor
|
/kind bug |
k8s-ci-robot
added
kind/bug
Contributor
|
/lgtm |
k8s-ci-robot
added
lgtm
nckturner
approved these changes
Sep 3, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Looking through the code in this function, it seems that we are iterating through the list three times to unpack it, but in the second iteration, we are appending to the wrong list, meaning that the input to the 3rd iteration can be wrong when a particular permission has more than one GroupPair associated with it.
Special notes for your reviewer:
This was picked up by a code scanner, and seemed like a simple enough change that I should propose it
Does this PR introduce a user-facing change?: