Skip to content

chunk target operatation for aws targetGroup#256

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nckturner:cherry-pick-a10dd9
Aug 26, 2021
Merged

chunk target operatation for aws targetGroup#256
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nckturner:cherry-pick-a10dd9

Conversation

@nckturner
Copy link
Contributor

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind bug

What this PR does / why we need it:
AWS ELBv2 API will intermittently reject targets operations in large chunks according to its availability.
Currently we register all targets in a single batch call, which might fail indefinitely for specific users.

Which issue(s) this PR fixes:

Fixes #254

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Register/Deregister Targets in chunks for AWS TargetGroup

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 25, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2021
Copy link
Member

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit a313ec7 into kubernetes:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cherry pick #101592

3 participants