Remove providerless build option #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
size/M
nckturner
force-pushed
the
remove-providerless-build
branch
from
8ae4fdd to
6bb0f62
Compare
* The external cloud provider does not need a special build configuration for a "providerless" build. * Run gofmt with go1.17 * Fix quoting in hack/cherry-pick-kk.sh and improve logic, including using git features instead of sed, and using a 3way merge to allow it to work in the event of conflicts.
nckturner
force-pushed
the
remove-providerless-build
branch
from
6bb0f62 to
b505768
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external cloud provider does not need a special build configuration
for a "providerless" build.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Remove extraneous build option.
Does this PR introduce a user-facing change?: