Set EC2 instance cache max age to 10 mins - #259
Merged
Conversation
nckturner
force-pushed
the
cherry-pick-2bc5ff
branch
from
August 26, 2021 21:02
45fefe5 to
f2d9ff6
Compare
kishorj
approved these changes
Aug 26, 2021
nckturner
force-pushed
the
cherry-pick-2bc5ff
branch
from
August 26, 2021 21:16
f2d9ff6 to
706c81c
Compare
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The AWS in-tree controller caches the EC2 instance information indefinitely unless the nodes get scaled up. In case the EC2 instances have multiple security groups attached, this caching strategy leads to inconsistency between the actual EC2 instance configuration in AWS and the controller's view of the EC2 instance information. This PR sets the maximum age of 10 minutes to the EC2 instance cache.
Once the security group requirements are satisfied, controller will be able to fetch the new EC2 information, and get past the following errors without scaling up the nodes -
Which issue(s) this PR fixes:
Fixes #255
Special notes for your reviewer:
Testing
Does this PR introduce a user-facing change?: