Add a unit test for sets_ippermissions #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
approved
nckturner
force-pushed
the
unit-test-sets_ippermissions
branch
from
4725755 to
b67eb83
Compare
Contributor
Author
|
/retest |
nckturner
force-pushed
the
unit-test-sets_ippermissions
branch
from
b67eb83 to
830ab71
Compare
M00nF1sh
reviewed
Sep 7, 2021
nckturner
force-pushed
the
unit-test-sets_ippermissions
branch
from
830ab71 to
5e0e4a1
Compare
wongma7
approved these changes
Sep 7, 2021
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Add a test for
sets_ippermissions_test.gowhich is had a bug that is fixed in #250.Special notes for your reviewer:
merge #250 first.
Does this PR introduce a user-facing change?: