Add support for RBN-based node names - #286
Merged
Merged
Conversation
johngmyers
reviewed
Nov 24, 2021
Update pkg/providers/v1/aws.go Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
Member
|
/lgtm |
Member
|
/kind feature |
nckturner
approved these changes
Nov 30, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, nckturner, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
AWS recently launched support for instance DNS host names based on instance ID rather than ipv4.
This PR adds support for nodes with those DNS hostnames
Which issue(s) this PR fixes:
Fixes #285
Special notes for your reviewer:
Originally, node names were suffixed with the domain name. AWS CCM is to my knowledge the only CCM that do not use only the hostnames. As a consequence, all relevant k8s components need set
--hostname-overrideas kubelet et.al cannot automatically determine the hostname. Because of this, with RBN, CCM expects only the hostname. Thekubectl get nodesoutput then looks like this:Does this PR introduce a user-facing change?: