Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate service with mixed protocols #287

Merged
merged 1 commit into from Nov 24, 2021

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Nov 24, 2021

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Cherry pick kubernetes/kubernetes#105361 from upstream. This is required until we explicitly support mixed protocols in the external CCM.

The AWS in-tree controller doesn't support mixed protocols for service. This PR adds validation logic to the AWS cloudprovider to not provision any load balancer for service with mixed protocols so that the MixedProtocolLBService feature gate can be enabled safely on AWS.

kubernetes/enhancements#1435

Special notes for your reviewer:

Manually tested with feature-gate MixedProtocolLBService=true

  • services with mixed protocol do not get reconciled, controller reports event "... mixed protocol is not supported for LoadBalancer"
  • CLB with TCP works as expected, CLB with UDP does not get reconciled as usual
  • NLB with TCP, or NLB with UDP protocol is functional
  • empty protocol defaults to TCP

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2021
@kishorj
Copy link
Contributor

kishorj commented Nov 24, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 488b215 into kubernetes:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants