Skip to content

Tag on create#293

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
olemarkus:tag-on-create
Jan 5, 2022
Merged

Tag on create#293
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
olemarkus:tag-on-create

Conversation

@olemarkus
Copy link
Copy Markdown
Member

@olemarkus olemarkus commented Dec 8, 2021 

Target groups, security groups and listeners are now tagged on creation rather than as separate API calls.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2021
@rifelpet
Copy link
Copy Markdown
Member

rifelpet commented Dec 8, 2021

LGTM though I'm curious if all AWS partitions support tag-on-create for these resource types

@olemarkus olemarkus mentioned this pull request Dec 8, 2021
Merged
@olemarkus
Copy link
Copy Markdown
Member Author

olemarkus commented Dec 9, 2021

At least AWS Load Balancer Controller use tag on create for these resources.
CCM also use them on the other resources it manages.

@nckturner
Copy link
Copy Markdown
Contributor

nckturner commented Dec 30, 2021

I'm unable to find information about ELB tag on create status across all regions, but if AWS Load Balancer Controller uses it then I'm comfortable using it.

@olemarkus
Copy link
Copy Markdown
Member Author

olemarkus commented Dec 30, 2021

As I understand it from this code tags are applied on create.

@nckturner
Copy link
Copy Markdown
Contributor

nckturner commented Jan 5, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@nckturner
Copy link
Copy Markdown
Contributor

nckturner commented Jan 5, 2022

/retest

@nckturner
Copy link
Copy Markdown
Contributor

nckturner commented Jan 5, 2022

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit a8ac0c4 into kubernetes:master Jan 5, 2022
@olemarkus olemarkus mentioned this pull request Jan 16, 2022
Closed
@nckturner nckturner mentioned this pull request Mar 4, 2022
Merged
@olemarkus olemarkus mentioned this pull request May 6, 2022
Closed
@Fedosin Fedosin mentioned this pull request Aug 11, 2022
Merged
@JoelSpeed JoelSpeed mentioned this pull request Oct 28, 2022
Merged
This was referenced Nov 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

@nckturner nckturner Awaiting requested review from nckturner

Assignees

@nckturner nckturner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olemarkus @rifelpet @nckturner @k8s-ci-robot