Use go-runner as base image#295
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Dec 28, 2021
Merged
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
approved
Member
|
Been thinking if kops should also log CCM to disk. This will certainly help with that. /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it: To collect/persist logs (versus just emitting to stdout/stderr and letting container runtime deal with them) go-runner should be used. kubernetes already uses this image as base for apiserver, scheduler, and KCM https://github.com/kubernetes/kubernetes/blob/release-1.23/build/common.sh#L94. Since cloud provider is a "kubernetes component" basically split off from KCM it makes sense to use this image as base for cloud provider as well. More details are here: https://github.com/kubernetes/release/tree/master/images/build/go-runner.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: