E2E framework by nckturner · Pull Request #304 · kubernetes/cloud-provider-aws

nckturner · 2022-02-04T16:52:44Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add e2e test runner based on kubetest2.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Requires:

EDIT: this will be required in a future iteration, once we take full advantage of kubetest2.

Does this PR introduce a user-facing change?:

None

charts/aws-cloud-controller-manager/Chart.yaml

hack/install-e2e-tools.sh

adityavenneti

/approve

linux-foundation-easycla · 2022-02-16T22:24:18Z

The committers are authorized under a signed CLA.

✅ Nicholas Turner (af05989)

hack/e2e/run.sh

wongma7 · 2022-02-16T22:57:10Z

hack/e2e/run.sh

+      -v 2 \
+      --up \
+      --run-id=${test_run_id} \
+      --cloud-provider=aws \


need to build and deploy a ccm as built from the current PR

The way kops solves this is to upload the image as file and sideload it. May be doable for CCM too.

Spoke with @olemarkus about this possibility and it sound interesting, (especially when using the ECR kubelet image credential provider). He is going to do some exploratory work but in the meantime we will just push to ECR and expect an ECR repository to be present in the current account.

wongma7 · 2022-03-01T00:15:58Z

hack/e2e/run.sh

+
+echo "Building and pushing test driver image to ${IMAGE_NAME}:${IMAGE_TAG}"
+aws ecr get-login-password --region "${REGION}" | docker login --username AWS --password-stdin "${AWS_ACCOUNT_ID}.dkr.ecr.${REGION}.amazonaws.com"
+docker tag "${IMAGE}" "${IMAGE_NAME}:${IMAGE_TAG}"


is IMAGE expected to be an arg? no magic allowed, it should be defined at the top with other args

might need some prefixes to disambiguate IMAGE from IMAGE_NAME and IMAGE_TAG... IMAGE is the image that is assumed t o exist, IMAGE_NAME:IMAGE_TAG is the destination to push it to

Updated to use $MAKE_ prefix to differentiate variables passed from Makefile.

wongma7 · 2022-03-01T00:19:04Z

tests/e2e/testsuites/specs.go

+
+//. "github.com/onsi/ginkgo"
+
+type ServiceDetails struct {


I don't really understand the organization of these files

example_tester.go
specs.go
testsuites.go

plz shuffle them or add some comments explaining it

- Use ginkgo binary to run the tests for now instead of using the kops kubetest2 tester. We can improve this once we have the ability to run arbitrary e2e.test binaries with the kops tester.

wongma7 · 2022-03-01T19:53:10Z

/lgtm

k8s-ci-robot · 2022-03-01T19:53:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adityavenneti, nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nckturner,wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nckturner · 2022-03-01T20:10:57Z

/unhold

…stream-release-1.22 Automated cherry pick of #304: E2E framework

nckturner changed the title ~~E2e framework~~ E2E framework Feb 4, 2022

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 4, 2022

k8s-ci-robot requested review from andrewsykim and wongma7 February 4, 2022 16:53

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022

nckturner force-pushed the e2e-framework branch from 930ccbc to 04c310c Compare February 4, 2022 16:59

nckturner commented Feb 4, 2022

View reviewed changes

charts/aws-cloud-controller-manager/Chart.yaml Outdated Show resolved Hide resolved

nckturner force-pushed the e2e-framework branch 2 times, most recently from 276366c to b0353e9 Compare February 4, 2022 18:56

nckturner commented Feb 4, 2022

View reviewed changes

hack/install-e2e-tools.sh Outdated Show resolved Hide resolved

adityavenneti approved these changes Feb 11, 2022

View reviewed changes

nckturner force-pushed the e2e-framework branch from bbf2ed6 to 952f23b Compare February 16, 2022 20:23

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 16, 2022

nckturner force-pushed the e2e-framework branch from 131aeab to af05989 Compare February 16, 2022 22:40

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 16, 2022

wongma7 reviewed Feb 16, 2022

View reviewed changes

hack/e2e/run.sh Show resolved Hide resolved

nckturner force-pushed the e2e-framework branch from af05989 to e7daddb Compare February 16, 2022 22:54

wongma7 reviewed Feb 16, 2022

View reviewed changes

nckturner force-pushed the e2e-framework branch 4 times, most recently from 6cdb3eb to d0c3af7 Compare February 28, 2022 23:06

wongma7 reviewed Mar 1, 2022

View reviewed changes

nckturner force-pushed the e2e-framework branch from d0c3af7 to 5652df3 Compare March 1, 2022 01:23

Simple E2E runner

0772974

- Use ginkgo binary to run the tests for now instead of using the kops kubetest2 tester. We can improve this once we have the ability to run arbitrary e2e.test binaries with the kops tester.

nckturner force-pushed the e2e-framework branch from 5652df3 to 0772974 Compare March 1, 2022 07:01

k8s-ci-robot assigned wongma7 Mar 1, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022

k8s-ci-robot merged commit 564792e into kubernetes:master Mar 1, 2022

nckturner mentioned this pull request Mar 1, 2022

Add e2e test presubmits to cloud-provider-aws kubernetes/test-infra#25460

Merged

wongma7 mentioned this pull request Mar 1, 2022

Automated cherry pick of #304: E2E framework #310

Merged

k8s-ci-robot added a commit that referenced this pull request Mar 1, 2022

Merge pull request #310 from wongma7/automated-cherry-pick-of-#304-up…

536efad

…stream-release-1.22 Automated cherry pick of #304: E2E framework

This was referenced May 13, 2022

Cherry pick E2E test changes and fix failing tagging controller test for 1.21 #369

Merged

Cherry pick E2E test changes and fix failing tagging controller test for 1.20 #370

Merged

nckturner mentioned this pull request Dec 5, 2022

Update OWNERS_ALIASES kubernetes-sigs/aws-encryption-provider#90

Merged

Conversation

nckturner commented Feb 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adityavenneti left a comment

Choose a reason for hiding this comment

Uh oh!

linux-foundation-easycla bot commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

wongma7 Feb 16, 2022

Choose a reason for hiding this comment

Uh oh!

olemarkus Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

nckturner Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

wongma7 Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

wongma7 Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

nckturner Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

wongma7 Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

wongma7 commented Mar 1, 2022

Uh oh!

k8s-ci-robot commented Mar 1, 2022

Uh oh!

nckturner commented Mar 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nckturner commented Feb 4, 2022 •

edited

Loading

linux-foundation-easycla bot commented Feb 16, 2022 •

edited

Loading