Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get e2e tests working in prow #312

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Get e2e tests working in prow #312

merged 1 commit into from
Mar 3, 2022

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Mar 2, 2022 •
edited
Loading

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind failing-test

What this PR does / why we need it:

Fixes failing e2e test.

  • Create test run directory earlier to avoid failure
  • Install e2e prereqs

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@nckturner
Copy link
Contributor Author

/test pull-cloud-provider-aws-e2e

@nckturner
Copy link
Contributor Author

/test pull-cloud-provider-aws-e2e

@nckturner
Copy link
Contributor Author

/test pull-cloud-provider-aws-e2e
/test pull-cloud-provider-aws-test

@nckturner nckturner changed the title Create test run directory earlier to avoid failure Get e2e tests working in prow Mar 3, 2022
@nckturner
Fix e2e failures
b50bd5c 
* Create test run directory earlier to avoid failure
* Install e2e prereqs
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2022
wongma7
wongma7 reviewed Mar 3, 2022
View reviewed changes
hack/e2e/run.sh
popd

if [[ "${DOWN}" = "yes" ]]; then
kops delete cluster --name "${CLUSTER_NAME}" --yes
${test_run}/kops delete cluster --name "${CLUSTER_NAME}" --yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did the binary get here? is kops also an e2e-tool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, its downloaded by the kubetest2 kops deployer: https://github.com/kubernetes/kops/blob/master/tests/e2e/pkg/kops/download.go#L32-L55

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we call kubetest2 --down (or whatever the right arguments are) then instead, so we don't have to care about that implementation detail?

@wongma7
Copy link
Contributor

wongma7 commented Mar 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 62d7c47 into kubernetes:master Mar 3, 2022
@prasita123 prasita123 mentioned this pull request Mar 4, 2022
Merged
nckturner added a commit that referenced this pull request Mar 4, 2022
@nckturner
Merge pull request #315 from prasita123/automated-cherry-pick-of-#312…
940a081 
…-upstream-release-1.22

Automated cherry pick of #312: Fix e2e failures
This was referenced May 13, 2022
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 13, 2022
@k8s-ci-robot
Merge pull request #370 from saurav-agarwalla/automated-cherry-pick-o…
2d1646f 
…f-#304-#312-upstream-release-1.20

Cherry pick E2E test changes and fix failing tagging controller test for 1.20
k8s-ci-robot added a commit that referenced this pull request May 13, 2022
@k8s-ci-robot
Merge pull request #369 from saurav-agarwalla/automated-cherry-pick-o…
0712fe8 
…f-#304-#312-upstream-release-1.21

Cherry pick E2E test changes and fix failing tagging controller test for 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 wongma7 left review comments

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nckturner @wongma7 @k8s-ci-robot