Fix version #317
Merged
Fix version #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix ldflags. * Use `git describe --dirty --tags --match='v*'` for the git version. * This will produce just the tag on a commit which is tagged. * If not tagged it will be something like `v1.23.0-alpha.0-16-g67cbbd12-dirty` referencing the most recent tag on the current branch.
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
Contributor
Author
|
/assign @wongma7 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git describe --dirty --tags --match='v*'for the git version.v1.23.0-alpha.0-16-g67cbbd12-dirtyreferencing the most recent tag on the current branch.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix the version command.
Which issue(s) this PR fixes:
Fixes #247
Does this PR introduce a user-facing change?: