Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version #317

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix version #317

merged 1 commit into from
Mar 7, 2022

Conversation

nckturner
Copy link
Contributor

  • Fix ldflags.
  • Use git describe --dirty --tags --match='v*' for the git version.
  • This will produce just the tag on a commit which is tagged.
  • If not tagged it will be something like v1.23.0-alpha.0-16-g67cbbd12-dirty
    referencing the most recent tag on the current branch.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix the version command.

Which issue(s) this PR fixes:

Fixes #247

Does this PR introduce a user-facing change?:

Fixes version command.

* Fix ldflags.
* Use `git describe --dirty --tags --match='v*'` for the git version.
* This will produce just the tag on a commit which is tagged.
* If not tagged it will be something like `v1.23.0-alpha.0-16-g67cbbd12-dirty`
  referencing the most recent tag on the current branch.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@nckturner
Copy link
Contributor Author

/assign @wongma7

@wongma7
Copy link
Contributor

wongma7 commented Mar 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--version flag is broken
3 participants