Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs #336

Merged
merged 3 commits into from
Apr 9, 2022
Merged

Docs #336

merged 3 commits into from
Apr 9, 2022

Conversation

nckturner
Copy link
Contributor

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind documentation

What this PR does / why we need it:

  • Update changelog.py to support PRs without merge commits
  • Add v1.22.0 to CHANGELOG.md

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 9, 2022
@k8s-ci-robot
Copy link
Contributor

@nckturner: This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2022
@wongma7
Copy link
Contributor

wongma7 commented Apr 9, 2022

could we make master branch source of truth for CHANGELOGs? how k/k does it is they have master branch changelogs https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG and then a bot updates the per-branch changelogs https://github.com/kubernetes/kubernetes/blob/release-1.22/CHANGELOG/CHANGELOG-1.22.md

We don't have a bot but I don't think it is super necessary to have useful per-branch changelogs anyway

@wongma7
Copy link
Contributor

wongma7 commented Apr 9, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2022
@wongma7
Copy link
Contributor

wongma7 commented Apr 9, 2022

Wait no, this PR is already targeting master branch so yes master branch is already source of truth. MY B ignore prev comment -_-

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2022
@wongma7
Copy link
Contributor

wongma7 commented Apr 9, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nckturner
Copy link
Contributor Author

could we make master branch source of truth for CHANGELOGs?

That's what I was doing, what do you mean?

@k8s-ci-robot k8s-ci-robot merged commit 05be343 into kubernetes:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants