Use short git tag for version and images#352
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom May 10, 2022
Merged
Conversation
k8s-ci-robot
added
do-not-merge/release-note-label-needed
Member
Author
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Member
Author
|
/release-note-none |
k8s-ci-robot
added
release-note-none
rifelpet
approved these changes
May 10, 2022
Comment on lines
+18
to
+19
| _GIT_TAG: 'v99999999-v12345' | ||
| _SHORT_TAG: '${_GIT_TAG:10}' |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Is it possible to have a comment here saying something like # Remove date prefix (first 10 characters) to create valid semver version, e.g. v20220510-v1.24.0-alpha.0-15-g09bd268 => v1.24.0-alpha.0-15-g09bd268
Member
Author
|
/assign @nckturner |
k8s-ci-robot
added
the
lgtm
Member
|
I'm going to approve because this feels consistent with #350 and is breaking builds. cc @nckturner /approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, justinsb, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
May 11, 2022
…tream-release-1.23 Automated cherry pick of #352: Use short git tag for version and images
k8s-ci-robot
added a commit
that referenced
this pull request
May 15, 2022
…tream-release-1.22 Automated cherry pick of #352: Use short git tag for version and images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #339
Does this PR introduce a user-facing change?: