Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use short git tag for version and images #352

Merged
merged 1 commit into from
May 10, 2022
Merged

Use short git tag for version and images #352

merged 1 commit into from
May 10, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented May 10, 2022 •
edited
Loading

Fixes: #339

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2022
@k8s-ci-robot k8s-ci-robot requested review from jaypipes and justinsb May 10, 2022 11:26
@hakman
Copy link
Member Author

hakman commented May 10, 2022

/triage accepted
/kind bug

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 10, 2022
@hakman
Copy link
Member Author

hakman commented May 10, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 10, 2022
rifelpet
rifelpet approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should fix the image builds broken by #350

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/cloud-provider-aws-push-images/1523933803632922624

/lgtm

cloudbuild.yaml
Comment on lines +18 to +19
_GIT_TAG: 'v99999999-v12345'
_SHORT_TAG: '${_GIT_TAG:10}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference: https://cloud.google.com/build/docs/configuring-builds/use-bash-and-bindings-in-substitutions#bash_parameter_expansions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have a comment here saying something like # Remove date prefix (first 10 characters) to create valid semver version, e.g. v20220510-v1.24.0-alpha.0-15-g09bd268 => v1.24.0-alpha.0-15-g09bd268

@hakman
Copy link
Member Author

hakman commented May 10, 2022

/assign @nckturner

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2022
@hakman hakman mentioned this pull request May 10, 2022
Merged
@justinsb
Copy link
Member

I'm going to approve because this feels consistent with #350 and is breaking builds.

cc @nckturner

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, justinsb, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 706dbf9 into kubernetes:master May 10, 2022
@hakman hakman deleted the short_git_tag branch May 10, 2022 12:52
@hakman hakman mentioned this pull request May 10, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request May 11, 2022
@k8s-ci-robot
Merge pull request #353 from hakman/automated-cherry-pick-of-#352-ups…
c8424eb 
…tream-release-1.23

Automated cherry pick of #352: Use short git tag for version and images
@hakman hakman mentioned this pull request May 12, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request May 15, 2022
@k8s-ci-robot
Merge pull request #363 from hakman/automated-cherry-pick-of-#352-ups…
20b4aad 
…tream-release-1.22

Automated cherry pick of #352: Use short git tag for version and images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@jaypipes jaypipes Awaiting requested review from jaypipes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

@nckturner nckturner

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: version string "v20220409-v1.23.0" doesn't match expected regular expression
5 participants
@hakman @justinsb @k8s-ci-robot @rifelpet @nckturner