Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick E2E test changes and fix failing tagging controller test for 1.20 #370

Merged
merged 5 commits into from
May 13, 2022
Merged

Cherry pick E2E test changes and fix failing tagging controller test for 1.20 #370

merged 5 commits into from
May 13, 2022

Conversation

saurav-agarwalla
Copy link
Contributor

@saurav-agarwalla saurav-agarwalla commented May 13, 2022 •
edited by nckturner
Loading

Cherry pick of #304 #312 on release-1.20.

#304: Simple E2E runner
#312: Fix e2e failures

For details on the cherry pick process, see the cherry pick requests page.

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @saurav-agarwalla. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 13, 2022
@nckturner
Copy link
Contributor

/ok-to-test
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 13, 2022
nckturner and others added 4 commits May 13, 2022 11:19
@nckturner @saurav-agarwalla
Simple E2E runner
a185acf 
- Use ginkgo binary to run the tests for now instead of using the kops
kubetest2 tester.  We can improve this once we have the ability to run
arbitrary e2e.test binaries with the kops tester.
@nckturner @saurav-agarwalla
Fix e2e failures
42f6b38 
* Create test run directory earlier to avoid failure
* Install e2e prereqs
@saurav-agarwalla
Update Kubernetes cluster version for 1.20
ba0b922
@saurav-agarwalla
Fix issue with flag causing test failures
227f487 
`make test` is now successful (it was failing prior to this change).
@saurav-agarwalla saurav-agarwalla force-pushed the automated-cherry-pick-of-#304-#312-upstream-release-1.20 branch from 33de1c0 to 227f487 Compare May 13, 2022 15:20
@saurav-agarwalla saurav-agarwalla changed the title Automated cherry pick of #304: Simple E2E runner #312: Fix e2e failures Cherry pick E2E test changes and fix failing tagging controller test for 1.20 May 13, 2022
@saurav-agarwalla saurav-agarwalla mentioned this pull request May 13, 2022
Closed
@nckturner
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, saurav-agarwalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2d1646f into kubernetes:release-1.20 May 13, 2022
@saurav-agarwalla saurav-agarwalla deleted the automated-cherry-pick-of-#304-#312-upstream-release-1.20 branch June 22, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@nckturner nckturner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saurav-agarwalla @k8s-ci-robot @nckturner