From 68ec012adc4b3dff9b8b697918909b073e5fe1ed Mon Sep 17 00:00:00 2001
From: babykart <babykart@gmail.com>
Date: Fri, 26 Apr 2024 20:37:10 +0200
Subject: [PATCH] fix(occm): Empty nodeSelector by default

Signed-off-by: babykart <babykart@gmail.com>
---
 charts/openstack-cloud-controller-manager/README.md   | 9 +++++++++
 charts/openstack-cloud-controller-manager/values.yaml | 7 ++++---
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/charts/openstack-cloud-controller-manager/README.md b/charts/openstack-cloud-controller-manager/README.md
index 77c224bbf2..d989313383 100644
--- a/charts/openstack-cloud-controller-manager/README.md
+++ b/charts/openstack-cloud-controller-manager/README.md
@@ -55,6 +55,15 @@ tolerations:
     effect: NoSchedule
 ```
 
+## NodeSelector
+
+To deploy OCCM to control-plane nodes only, adjust the nodeSelectors in the chart:
+
+```yaml
+nodeSelector:
+  node-role.kubernetes.io/control-plane: "true"
+```
+
 ## Unsupported configurations
 
 - The chart does not support the mounting of custom `clouds.yaml` files. Therefore, the following config values in the `[Global]` section won’t have any effect:
diff --git a/charts/openstack-cloud-controller-manager/values.yaml b/charts/openstack-cloud-controller-manager/values.yaml
index f656d6bd10..2918b04998 100644
--- a/charts/openstack-cloud-controller-manager/values.yaml
+++ b/charts/openstack-cloud-controller-manager/values.yaml
@@ -46,9 +46,10 @@ livenessProbe: {}
 # Set readinessProbe in the same way like livenessProbe
 readinessProbe: {}
 
-# Set nodeSelector where the controller should run, i.e. controlplane nodes
-nodeSelector:
-  node-role.kubernetes.io/control-plane: ""
+# Set nodeSelector where the controller should run.
+nodeSelector: {}
+  # i.e. controlplane nodes
+  # node-role.kubernetes.io/control-plane: "true"
 
 # Set tolerations for nodes where the controller should run, i.e. node
 # should be uninitialized, controlplane...