Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manila-csi-plugin] Add manila jobs to test-infra #1635

Closed
ramineni opened this issue Aug 31, 2021 · 14 comments
Closed

[manila-csi-plugin] Add manila jobs to test-infra #1635

ramineni opened this issue Aug 31, 2021 · 14 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ramineni
Copy link
Contributor

ramineni commented Aug 31, 2021

Is this a BUG REPORT or FEATURE REQUEST?:
This issue is to track the progress of manila jobs to be added to test-infra
Parent-issue: #1613

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

  • openstack-cloud-controller-manager(or other related binary) version:
  • OpenStack version:
  • Others:
@ramineni
Copy link
Contributor Author

/cc @gman0

@ramineni
Copy link
Contributor Author

manila sanity tests - kubernetes/test-infra#23520

@gman0
Copy link
Member

gman0 commented Oct 4, 2021

test-infra: kubernetes/test-infra#23878
manila e2e tests: #1656

@gman0
Copy link
Member

gman0 commented Oct 19, 2021

After discussion with @ramineni, she pointed out that CSI e2e tests actually should run in a multi-node environment in order for a CSI driver to be eligible for GA graduation.

I've pushed two PRs that I believed were good to have for manila-csi e2e:

They were supposed to give CI job authors the ability to spin a single-node Kubernetes cluster, when OpenStack VMs / multi-node setup isn't desired. This would save some time installing the respective OpenStack services, making the overall time for job runs shorter.

In order to satisfy GA requirements though, we've agreed to use a multi-node node environment for manila-csi e2e tests as well. For this reason I'll close the PRs mentioned above for now.

We also considered a possibility to have two tests for Manila: one with a single-node setup for regular PRs, and a second one with multi-node setup that would run e.g. when a new CPO release is tagged, or when deemed necessary. We may turn to this option later, e.g. depending on how much time it takes for the tests to run.

@ramineni
Copy link
Contributor Author

ramineni commented Oct 20, 2021

After discussion with @ramineni, she pointed out that CSI e2e tests actually should run in a multi-node environment in order for a CSI driver to be eligible for GA graduation.

Re-wording my intent here again , IMO its always recommended to use to production env setup in CI instead of going with local cluster if it can be done . As discussed with @gman0 I understand that there is no as such issues/bottle neck to use multi node , so I suggest we should go with that setup instead.

@gman0 we don't maintain status as such for our plugins (alpha, beta, GA) AFAIK . This is one of the criteria we have come across while driving CSI migration , that's one of the reason we have started migrating the jobs to multi node setup thereafter. So I suggest not to go back again to use local-up-cluster.sh or other unless its a necessity to run the jobs.

But I agree that we dont need to deploy the services that are not required/used for the job. We can update/split the same as required.

@gman0
Copy link
Member

gman0 commented Nov 10, 2021

We don't have CSI sanity tests currently enabled right?

@ramineni
Copy link
Contributor Author

@ramineni
Copy link
Contributor Author

@gman0 And also, do you have plans to enable other e2e test suites for this release. IMO its good to have when you are bumping sidecars , to see no breakage is there.

@gman0
Copy link
Member

gman0 commented Nov 17, 2021

@ramineni yes of course, I'm just busy with other things at the moment.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2022
@gman0
Copy link
Member

gman0 commented Feb 15, 2022

I think we can close this? Most of the e2e test suites have been integrated to manila-csi, with the exception of FsGroupChangePolicyTestSuite that I still need to get around to look at. See notes here #1762 (comment).

@ramineni
Copy link
Contributor Author

@gman0 +1

@ramineni
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@ramineni: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants