Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cinder-csi-plugin]Add toleration to CSI daemonset #1276

Merged
merged 1 commit into from Oct 22, 2020
Merged

[Cinder-csi-plugin]Add toleration to CSI daemonset #1276

merged 1 commit into from Oct 22, 2020

Conversation

jichenjc
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1237

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build failed.

@jichenjc
Copy link
Contributor Author 

2020-10-16 08:06:35.581413 | ubuntu-xenial-citynetwork |   Normal   Provisioning        45s (x9 over 5m1s)  cinder.csi.openstack.org_csi-cinder-controllerplugin-0_6eabea9c-220d-412f-9ed5-f7a40b164c45  External provisioner is provisioning volume for claim "default/csi-pvc-cinderplugin"
2020-10-16 08:06:35.581466 | ubuntu-xenial-citynetwork |   Warning  ProvisioningFailed  45s (x9 over 5m)    cinder.csi.openstack.org_csi-cinder-controllerplugin-0_6eabea9c-220d-412f-9ed5-f7a40b164c45  failed to provision volume with StorageClass "csi-sc-cinderplugin": rpc error: code = Internal desc = CreateVolume failed with error Expected HTTP response code [202] when accessing [POST https://lon1.citycloud.com:8776/v3/06ce5499f716488d985845cddcabdc16/volumes], but got 413 instead
2020-10-16 08:06:35.581517 | ubuntu-xenial-citynetwork | {"overLimit": {"message": "VolumeLimitExceeded: Maximum number of volumes allowed (10) exceeded for quota 'volumes'.", "code": 413, "retryAfter": "0"}}
2020-10-16 08:06:35.581555 | ubuntu-xenial-citynetwork |   Normal  ExternalProvisioning  15s (x21 over 5m1s)  persistentvolume-controller  waiting for a volume to be created, either by external provisioner "cinder.csi.openstack.org" or manually created by system administrator

@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 16, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 19, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 19, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 19, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 20, 2020

Build succeeded.

@ramineni
Copy link
Contributor

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2020
@adisky
Copy link
Contributor

adisky commented Oct 22, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 403dcd1 into kubernetes:master Oct 22, 2020
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Sep 6, 2021
@openstack-gerrit
Update git submodules
d11fef6 
* Update magnum from branch 'master'
  to 6951ac4fc6b6178637fac7bd5d05096adb5c6bdc
  - Merge "Add toleration to CSI nodeplugin"
  - Add toleration to CSI nodeplugin
    
    This commit allows the CSI nodeplugin to start on machines with taints.
    A use case is nodegroups; a dedicated machine (e.g. ASICs and GPU) will
    join the cluster with a pre-defined taint so that pods can't grab
    valuable resources. However the taint currently stops the node from
    starting the plugin and getting a node ID, so we cannot use cinder
    volumes within pods.
    
    This commit ports the work done by jichenjc
    (kubernetes/cloud-provider-openstack#1276) into
    Magnum fixing the issue here too.
    
    Story: 2007048
    Task: 42097
    
    Change-Id: I8dec787660604d52156d71617d2bdda73fb62e9c
openstack-mirroring pushed a commit to openstack/magnum that referenced this pull request Sep 6, 2021
@DavidFair @brtkwr
Add toleration to CSI nodeplugin
fa4a6ba 
This commit allows the CSI nodeplugin to start on machines with taints.
A use case is nodegroups; a dedicated machine (e.g. ASICs and GPU) will
join the cluster with a pre-defined taint so that pods can't grab
valuable resources. However the taint currently stops the node from
starting the plugin and getting a node ID, so we cannot use cinder
volumes within pods.

This commit ports the work done by jichenjc
(kubernetes/cloud-provider-openstack#1276) into
Magnum fixing the issue here too.

Story: 2007048
Task: 42097

Change-Id: I8dec787660604d52156d71617d2bdda73fb62e9c
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@jichenjc
Add toleration to CSI daemonset (kubernetes#1276)
0d4f916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] nodeplugin DaemonSet doesn't tolerate taints
4 participants
@jichenjc @ramineni @adisky @k8s-ci-robot