New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add octavia-ingress-controller #133

Merged
merged 1 commit into from Apr 30, 2018

Conversation

Projects
None yet
8 participants
@lingxiankong
Copy link
Contributor

lingxiankong commented Apr 23, 2018

What this PR does / why we need it:
An ingress controller implementation based on OpenStack Octavia service. A demo: https://youtu.be/ASSUMDvH_aE

Which issue this PR fixes:
fixes #114

Special notes for your reviewer:
This is the initial commit that can only be used for PoC purpose, a lot of things need to be improved such as:

  • Add documentation for how to deploy and test the ingress controller.
  • The unit test is missing
  • Add functional test
  • TLS support
  • Service name support

Release note:

Add OpenStack(Octavia) based ingress controller implementation.
@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 23, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 23, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 23, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 23, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 23, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 23, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 23, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 23, 2018

Build failed.

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 23, 2018

/ok-to-test

Makefile Outdated
@@ -36,12 +36,12 @@ endif
ifndef HAS_DEP
curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh
endif
dep ensure

This comment has been minimized.

@dims

dims Apr 23, 2018

Member

can you please remove the cd $(DEST)

This comment has been minimized.

@lingxiankong

lingxiankong Apr 23, 2018

Author Contributor

but without this change, i can see the failure when building the binary:

root@lingxian-docker-registry:~/cloud-provider-openstack# make octavia-ingress-controller
cd /home/ubuntu/go/src/k8s.io/cloud-provider-openstack
dep ensure
/home/ubuntu/cloud-provider-openstack is not within a known GOPATH/src
Makefile:39: recipe for target 'depend' failed
make: *** [depend] Error 1

not sure if I missed something.

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 23, 2018

Do you need to rebase against latest master? we need to get rid of the failures...

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 23, 2018

/retest
/test all

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 23, 2018

@lingxiankong please git clone under - /home/ubuntu/go/src/k8s.io/ so you have the cloud-provider-openstack in that k8s.io directory and things will be fine.

@lingxiankong lingxiankong force-pushed the lingxiankong:octavia_ingress_controller branch from f48fe47 to e385477 Apr 24, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 24, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 24, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 24, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 24, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 24, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 24, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 24, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 24, 2018

Build failed.

@mrhillsman

This comment has been minimized.

Copy link
Member

mrhillsman commented Apr 24, 2018

/retest

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 24, 2018

Build failed.

@lingxiankong

This comment has been minimized.

Copy link
Contributor Author

lingxiankong commented Apr 27, 2018

PR rebased

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 27, 2018

Build succeeded.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 27, 2018

Build succeeded.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 27, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 27, 2018

Build succeeded.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 27, 2018

Build failed.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 27, 2018

@lingxiankong

This comment has been minimized.

Copy link
Contributor Author

lingxiankong commented Apr 28, 2018

@dims @kiwik the 'cloud-provider-openstack-acceptance-test-lb-octavia' test keeps failing with the no available nodes for LoadBalancer service default/internal-http-nginx-service error, could you please take a look?

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 28, 2018

Build succeeded.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 28, 2018

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 28, 2018

/test cloud-provider-openstack-acceptance-test-lb-octavia

1 similar comment
@lingxiankong

This comment has been minimized.

Copy link
Contributor Author

lingxiankong commented Apr 29, 2018

/test cloud-provider-openstack-acceptance-test-lb-octavia

@liu-sheng

This comment has been minimized.

Copy link
Contributor

liu-sheng commented Apr 30, 2018

@lingxiankong oh, sorry forgot to reply you, the lbaas job will fail sometimes due to the unstable cloud provider of OpenLab CI environment, maybe we can ignore this job failure, since Dims has disable this job in master, see #138

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 30, 2018

/lgtm

@liu-sheng let's see if this merges

@lingxiankong if it does not merge, just rebase to clear the status(es) of the jobs and i can re-apply lgtm again

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 30, 2018

@lingxiankong lingxiankong force-pushed the lingxiankong:octavia_ingress_controller branch from cc2d345 to 901fead Apr 30, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 30, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 30, 2018

Build succeeded.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 30, 2018

Build succeeded.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 30, 2018

Build succeeded.

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 30, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 30, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 30, 2018

@theopenlab-ci

This comment has been minimized.

Copy link

theopenlab-ci bot commented Apr 30, 2018

Build succeeded.

@lingxiankong

This comment has been minimized.

Copy link
Contributor Author

lingxiankong commented Apr 30, 2018

@dims all green!

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 30, 2018

/lgtm

thanks for your patience @lingxiankong

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 30, 2018

@k8s-ci-robot k8s-ci-robot merged commit 36fb98e into kubernetes:master Apr 30, 2018

11 checks passed

cla/linuxfoundation lingxiankong authorized
Details
openlab/cloud-provider-openstack-acceptance-test-csi-cinder cloud-provider-openstack-acceptance-test-csi-cinder status: success
Details
openlab/cloud-provider-openstack-acceptance-test-e2e-conformance cloud-provider-openstack-acceptance-test-e2e-conformance status: success
Details
openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.10 cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.10 status: success
Details
openlab/cloud-provider-openstack-acceptance-test-k8s-cinder cloud-provider-openstack-acceptance-test-k8s-cinder status: success
Details
openlab/cloud-provider-openstack-acceptance-test-keystone-authentication-authorization cloud-provider-openstack-acceptance-test-keystone-authentication-authorization status: success
Details
openlab/cloud-provider-openstack-acceptance-test-standalone-cinder cloud-provider-openstack-acceptance-test-standalone-cinder status: success
Details
openlab/cloud-provider-openstack-unittest cloud-provider-openstack-unittest status: success
Details
pull-cloud-provider-openstack-check Job succeeded.
Details
pull-cloud-provider-openstack-test Job succeeded.
Details
tide In merge pool.
Details

@lingxiankong lingxiankong deleted the lingxiankong:octavia_ingress_controller branch May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment