Add description for the floating ip created for external service #433
Conversation
k8s-ci-robot
added
size/XS
|
Build failed.
|
|
Build succeeded.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
@lingxiankong just one question, after deleting the cluster shouldnt the floating ip automatically released to pool marking it as free , is it required to delete it everytime cluster/service is deleted? sorry if I misunderstood something here. |
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
Have similar thought, k8s cluster should touch LB (ingress) but not the floating ip ? |
This improvement is actually for magnum. In magnum, imagine that a user creates a k8s cluster and created some services of LoadBalancer type inside the cluster, there will be some octavia load balancers and new floating ips created accordingly. The lbs and floating ips will be deleted automatically if the user deletes the service explicitly inside the k8s cluster. However, In Magnum, if the user deletes the cluster without deleting the service first, even with this patch, the floating ip is not going to be deleted. In the public cloud, 'released to the pool' means the customer still need to be charged for the allocated resources. This PR is aiming to make it easy to find and delete those floating ips. Hope that explanation helps :-) |
|
/test cloud-provider-openstack-acceptance-test-keystone-authentication-authorization |
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.11 |
|
Build succeeded.
|
|
Build succeeded.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, lingxiankong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cloud-provider-openstack-test |
|
@lingxiankong thanks for the helpful info, really help ~ |
When user creates LoadBalancer type service in k8s cluster, a floating ip may be created and associated with the load balancer VIP. Magnum now could delete the load balancers automatically in the cluster pre-delete method, should also remove the floating ip as needed. This patch depends on the github PR for cloud-provider-openstack: kubernetes/cloud-provider-openstack#433 Story: 2004836 Change-Id: Ia553aff4e66033346c6bfe120a72992bec79e136
* Update magnum from branch 'master'
- Merge "[k8s_fedora_atomic] Delete floating ip for load balancer"
- [k8s_fedora_atomic] Delete floating ip for load balancer
When user creates LoadBalancer type service in k8s cluster, a floating
ip may be created and associated with the load balancer VIP. Magnum
now could delete the load balancers automatically in the cluster
pre-delete method, should also remove the floating ip as needed.
This patch depends on the github PR for cloud-provider-openstack:
kubernetes/cloud-provider-openstack#433
Story: 2004836
Change-Id: Ia553aff4e66033346c6bfe120a72992bec79e136
When user creates LoadBalancer type service in k8s cluster, a floating ip may be created and associated with the load balancer VIP. Magnum now could delete the load balancers automatically in the cluster pre-delete method, should also remove the floating ip as needed. This patch depends on the github PR for cloud-provider-openstack: kubernetes/cloud-provider-openstack#433 Story: 2004836 Change-Id: Ia553aff4e66033346c6bfe120a72992bec79e136 (cherry picked from commit f63761a)
Add description for the floating ip created for external service
What this PR does / why we need it:
fixes #432
Special notes for your reviewer:
When creating floating ip for external service, add the cluster and service information in the floating ip description field, so it's easy to query and delete outside of the cluster.
Release note: