New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm documentation update #656
Conversation
- InitializerConfiguration was removed in v1.14 and is no longer referenced in the documentation linked. - A known issue related to a race condition causes external addresses to not be listed when checking on nodes. A notice was put in to prevent the user from wondering why this is occurring.
Welcome @sfxworks! |
Hi @sfxworks. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@@ -28,6 +28,7 @@ | |||
``` | |||
|
|||
You can find an example kubeadm.conf in `manifests/controller-manager/kubeadm.conf`. Follow the usual steps to install the network plugin and then bootstrap the other nodes using `kubeadm join`. | |||
_Note, your nodes may not have an External IP address. This will cause logs and CNI to have have issues until the cluster provider is complete. Reference https://github.com/kubernetes/kubernetes/pull/75229 for further information._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add Note as seperate paragraph, right now its showing as combined.
you could start with >NOTE:
NOTE:
to make it visible as seperate paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Looks better like that. Updated!
Separated note reference based on comments
Thanks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adisky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* kubeadm documentation update - InitializerConfiguration was removed in v1.14 and is no longer referenced in the documentation linked. - A known issue related to a race condition causes external addresses to not be listed when checking on nodes. A notice was put in to prevent the user from wondering why this is occurring. * Separated note reference Separated note reference based on comments
What this PR does / why we need it:
This clarifies the kubeadm documentation for cloud-provider-openstack
Special notes for your reviewer:
This is based on troubleshooting assistance provided by a_sykim in the k8s slack channel #sig-cloud-provider