Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin] Add pagination support for ListVolumes #969

Merged
merged 1 commit into from Apr 23, 2020
Merged

[cinder-csi-plugin] Add pagination support for ListVolumes #969

merged 1 commit into from Apr 23, 2020

Conversation

ramineni
Copy link
Contributor

The binaries affected:

IMPORTANT: Please also add the binary name in the title, e.g.
[openstack-cloud-controller-manager]: Add UDP protocol support
unless the PR affects multiple binaries.

  • openstack-cloud-controller-manager
  • cinder-csi-plugin
  • k8s-keystone-auth
  • client-keystone-auth
  • octavia-ingress-controller
  • manila-csi-plugin
  • manila-provisioner
  • magnum-auto-healer
  • barbican-kms-plugin

What this PR does / why we need it:

Which issue this PR fixes:
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 12, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 12, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 12, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 12, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 12, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 12, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 12, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 12, 2020

Build failed.

@flaper87
Copy link
Contributor

/unassign @flaper87

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2020
@ramineni ramineni changed the title WIP:Add pagination support [cinder-csi-plugin] Add pagination support Apr 17, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2020
@ramineni ramineni changed the title [cinder-csi-plugin] Add pagination support [cinder-csi-plugin] Add pagination support for ListVolumes Apr 17, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build succeeded.

@ramineni
Copy link
Contributor Author

/assign @chrigl

@ramineni
Copy link
Contributor Author

/test cloud-provider-openstack-acceptance-test-csi-manila

@k8s-ci-robot
Copy link
Contributor

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 21, 2020

Build succeeded.

flaper87
flaper87 suggested changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@flaper87 flaper87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi folks! I don't work on this project anymore. Could you please remove me from the reviewers list? Thanks :)

@ramineni
Copy link
Contributor Author

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Contributor

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Contributor Author

/test cloud-provider-openstack-multinode-csi-migration-test

@k8s-ci-robot
Copy link
Contributor

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-multinode-csi-migration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni ramineni mentioned this pull request Apr 21, 2020
Merged
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 21, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 21, 2020

Build succeeded.

@adisky
Copy link
Contributor

adisky commented Apr 21, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2020
@chrigl
Copy link
Contributor

chrigl commented Apr 23, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrigl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4562037 into kubernetes:master Apr 23, 2020
This was referenced Jan 21, 2021
Merged
Closed
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@ramineni
Add pagination support (kubernetes#969)
99dd2a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaper87 flaper87 flaper87 requested changes

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

Assignees

@chrigl chrigl

@adisky adisky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ramineni @flaper87 @k8s-ci-robot @adisky @chrigl