Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller manifest update to point to apps/v1 to replace deprecated extensions/v1beta1 #253

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@davlloyd
Copy link
Contributor

davlloyd commented Sep 19, 2019

What this PR does / why we need it:
Update to the controller manifest vsphere-cloud-controller-manager-ds.yaml to enable support for Kubernetes 1.16 as the the daemonset controller api 'extensions/v1beta1' is now deprecated

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes #252

Special notes for your reviewer:
the apps/v1 API has been supported since Kubernetes 1.9 for DaemonSets so backwards compatible

Release note:

As per the 1.16 release notes the api tree 'extensions/v1beta1' has been deprecated. The replacement is fully backwards supported through to 1.9 as detailed in https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 19, 2019

Welcome @davlloyd!

It looks like this is your first PR to kubernetes/cloud-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 19, 2019

Hi @davlloyd. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davlloyd

This comment has been minimized.

Copy link
Contributor Author

davlloyd commented Sep 19, 2019

/assign @frapposelli

@frapposelli

This comment has been minimized.

Copy link
Member

frapposelli commented Sep 20, 2019

/ok-to-test

@dvonthenen

This comment has been minimized.

Copy link
Member

dvonthenen commented Sep 24, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dvonthenen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16ddfa1 into kubernetes:master Sep 24, 2019
16 checks passed
16 checks passed
Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
cla/linuxfoundation davlloyd authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-cloud-provider-vsphere-build Job succeeded.
Details
pull-cloud-provider-vsphere-integration-test Job succeeded.
Details
pull-cloud-provider-vsphere-unit-test Job succeeded.
Details
pull-cloud-provider-vsphere-verify-fmt Skipped.
pull-cloud-provider-vsphere-verify-lint Skipped.
pull-cloud-provider-vsphere-verify-markdown Skipped.
pull-cloud-provider-vsphere-verify-shell Skipped.
pull-cloud-provider-vsphere-verify-staticcheck Skipped.
pull-cloud-provider-vsphere-verify-vet Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.