Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasClusterID() and allow-untagged-cloud #71

Open
guettli opened this issue Jun 3, 2024 · 0 comments
Open

HasClusterID() and allow-untagged-cloud #71

guettli opened this issue Jun 3, 2024 · 0 comments

Comments

@guettli
Copy link

guettli commented Jun 3, 2024

Looking at the basic_main.go

	if !cloud.HasClusterID() {
		if config.ComponentConfig.KubeCloudShared.AllowUntaggedCloud {
			klog.Warning("detected a cluster without a ClusterID.  A ClusterID will be required in the future.  Please tag your cluster to avoid any future issues")
		} else {
			klog.Fatalf("no ClusterID found.  A ClusterID is required for the cloud provider to function properly.  This check can be bypassed by setting the allow-untagged-cloud option")
		}
	}

basic_main.go

But where is ClusterID actually used?

Afaik allow-untagged-cloud is deprecated, but afaik ClusterID does not get used.

The current state is confusing.

Please explain how a ccm should implement a ClusterID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant