Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug or FAQ section to testing.md #1537

Closed
tpepper opened this issue Dec 20, 2017 · 21 comments
Closed

add debug or FAQ section to testing.md #1537

tpepper opened this issue Dec 20, 2017 · 21 comments
Labels
area/contributor-guide Issues or PRs related to the contributor guide area/deflake Issues or PRs related to deflaking kubernetes tests kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@tpepper
Copy link
Member

tpepper commented Dec 20, 2017

The test landscape is complex for new comers. As @spiffxp described at KubeCon in the sig-testing meetup there is a subset of tests that is highly likely to fail. A simple PR that hits these types of failures can turn away new contributors, or cause them to take actions that increase infrastructure load (eg: re-run the coin-flip equivalent test until a heads is achieved or periodically rebase hoping a fix is now present and the test passes). A FAQ or debug section in https://github.com/kubernetes/community/blob/master/contributors/devel/testing.md would be useful to guide contributors toward understanding failures, seeing if they're hitting a top current flake (eg: http://velodrome.k8s.io/dashboard/db/bigquery-metrics?orgId=1), checking if there is an https://github.com/kubernetes/kubernetes/issues?q=is%3Aopen+is%3Aissue+label%3Akind%2Fflake issue is already tracking the problem or if they should "/kind flake", enable them to find and watch for the specific change they need to see merged before bothering to "/retest", etc.

@tpepper
Copy link
Member Author

tpepper commented Dec 20, 2017

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Dec 20, 2017
@tpepper
Copy link
Member Author

tpepper commented Dec 20, 2017

/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Dec 20, 2017
@tpepper
Copy link
Member Author

tpepper commented Dec 20, 2017

@guineveresaenger as discussed at KubeCon: If this makes sense and is put in place, probably a good link to hit in the new contrib guide.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 19, 2018
@nikhita
Copy link
Member

nikhita commented Apr 20, 2018

/remove-lifecycle rotten
/area contributor-guide

@tpepper @spiffxp I'm guessing this is still needed, right?

/cc @castrojo

@k8s-ci-robot k8s-ci-robot added area/contributor-guide Issues or PRs related to the contributor guide and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Apr 20, 2018
@MikeSpreitzer
Copy link
Member

I agree this is a big problem are for new, and even not-so-new, contributors. One additional degree of difficulty comes from the fact that sometimes the failure is in the test harness itself rather than the code being tested; as far as I can tell, the developer is given no clean delineation between these kinds of failures.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2018
@nikhita
Copy link
Member

nikhita commented Sep 19, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2018
@nikhita
Copy link
Member

nikhita commented Dec 18, 2018

/remove-lifecycle stale

Somewhat related: #2759

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2018
@spiffxp
Copy link
Member

spiffxp commented Jan 5, 2019

/area deflake

Guess what, a lot of this content once existed in k/community, and then got moved into k/sig-release/ephemera. (ref: kubernetes/sig-release#428)

In lieu of debugging/troubleshooting (which could cover a lot of things IMO) I would suggest a "test failure triage" guide or something, although I admit "troubleshooting" is probably a more common phrase.

IMO would best live in the contributor guide, because it's sort of a specific kind of issue triage.

@spiffxp
Copy link
Member

spiffxp commented Jan 5, 2019

/priority important-soon
/kind documentation

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 5, 2019
@spiffxp
Copy link
Member

spiffxp commented Jan 5, 2019

/area deflake
(now that the label exists)

@k8s-ci-robot k8s-ci-robot added the area/deflake Issues or PRs related to deflaking kubernetes tests label Jan 5, 2019
@mariantalla mariantalla added this to Inbox-needs prioritization in Deflaking kubernetes e2e tests Jan 8, 2019
@mariantalla
Copy link
Contributor

Can I take this one? I'm hoping to PR some additions as part of kubernetes/sig-release#428.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2019
@guineveresaenger
Copy link
Contributor

/remove-lifecycle stale

@mariantalla is this still something you're working on?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2019
@mariantalla
Copy link
Contributor

Hey @guineveresaenger - I've added all I had in mind with #3143. Does that cover everything under the scope of the issue?

@guineveresaenger
Copy link
Contributor

Awesome, will take a look soon!

@guineveresaenger
Copy link
Contributor

ah, heh! yes! we can totally close this. Thanks for pinging!
/close

Deflaking kubernetes e2e tests automation moved this from Inbox (unprioritized) to Done May 29, 2019
@k8s-ci-robot
Copy link
Contributor

@guineveresaenger: Closing this issue.

In response to this:

ah, heh! yes! we can totally close this. Thanks for pinging!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contributor-guide Issues or PRs related to the contributor guide area/deflake Issues or PRs related to deflaking kubernetes tests kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
No open projects
Development

No branches or pull requests

8 participants