Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add ProcMount option #1934
@feiskyer: GitHub didn't allow me to request PR reviews from the following users: rhatdan.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
I'm definitely in favor of more fine-grained controls than privileged. How is this handled by non-docker runtimes?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: smarterclayton
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
May 17, 2018
@jessfraz There are 2 options:
Today it is still container runtime handles the default OCI spec, so option 2 seems align more with today's model. But since the default is commonly agreed on, I do hope we can move the behavior up to kubelet gradually (option 1), instead of having a duplicated implementation in each container runtime, so I personally prefer option 1.
Another question is how do we support this in dockershim? I'm fine with not supporting it, but would like to know whether it is possible. :)
@yujuhong Do you have any preference?