New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more attributes into FlexVolume options field. #1985

Merged
merged 5 commits into from Jan 7, 2019

Conversation

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 29, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jun 14, 2018

/check-cla
/assign @saad-ali

@idealhack

This comment has been minimized.

Copy link
Member

idealhack commented Jul 4, 2018

/ok-to-test

@incfly

This comment has been minimized.

Copy link
Contributor

incfly commented Aug 6, 2018

Do you want this to be merged or I should close this? @idealhack @cblecker

@idealhack

This comment has been minimized.

Copy link
Member

idealhack commented Aug 7, 2018

@incfly Thanks for your contribution and please keep this open for now. We just need some reviewers and approvers here.

/assign @spiffxp @idvoretskyi @calebamiles

"kubernetes.io/pod.namespace": <string>,
"kubernetes.io/serviceAccount.name": <string>,
"kubernetes.io/pod.uid": <string>,

This comment has been minimized.

@idealhack

idealhack Aug 7, 2018

Member

Seems a good PR, but why these attributes are not the same as the source you referenced?

This comment has been minimized.

@spiffxp

spiffxp Aug 7, 2018

Member

This is missing a few options from
https://github.com/kubernetes/kubernetes/blob/4685df26ddc2c0778564ed77ec974da56bd52994/pkg/volume/flexvolume/driver-call.go#L48-L59

The arrangement/ordering is a bit weird. I would either match what's in the source, or alphabetize

This comment has been minimized.

@incfly

incfly Dec 7, 2018

Contributor

Done.

However, because of unfamilarity of the options, I just leave added options as <string>, which might be fine, because they're pretty self-evident.

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Sep 1, 2018

ping @incfly

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Dec 7, 2018

/lifecycle stale
/unassign
ping @incfly

@k8s-ci-robot k8s-ci-robot added size/S and removed size/L labels Dec 7, 2018

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Dec 7, 2018

@incfly

This comment has been minimized.

Copy link
Contributor

incfly commented Dec 18, 2018

ping @spiffxp

@idealhack

This comment has been minimized.

Copy link
Member

idealhack commented Dec 19, 2018

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Dec 19, 2018

/lgtm

@idealhack

This comment has been minimized.

Copy link
Member

idealhack commented Jan 5, 2019

/assign @cblecker

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, incfly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2c5614f into kubernetes:master Jan 7, 2019

3 checks passed

cla/linuxfoundation incfly authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment