Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal to introduce User Capabilities in Kubernetes and CRI. #2285

Closed
wants to merge 1 commit into from
Closed

Add proposal to introduce User Capabilities in Kubernetes and CRI. #2285

wants to merge 1 commit into from

Conversation

@filbranden
Copy link
Member

@filbranden filbranden commented Jun 19, 2018

To be discussed on SIG Node meeting of 2018-06-19.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jun 19, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dchen1107

Assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading


This is the most secure setting and should not be too hard to troubleshoot given
the failure scenario is likely to make the container fail quickly with a message
that is likely to point to the lack of specific capabilities.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth noting it will also just fail if the machine is running an older kernel (I can't remember off hand if it fails silently in runc though).

Loading

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Sep 17, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Loading

@redbaron
Copy link

@redbaron redbaron commented Sep 18, 2018

/remove-lifecycle stale

Loading

@james-callahan
Copy link

@james-callahan james-callahan commented Dec 17, 2018

Loading

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Mar 17, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Loading

@james-callahan
Copy link

@james-callahan james-callahan commented Mar 27, 2019

/remove-lifecycle stale

What is the current status of this proposal?

Loading

@filbranden
Copy link
Member Author

@filbranden filbranden commented Mar 27, 2019

I haven't had time to push it forward. I'll be away for the next couple of months, so I don't expect to be able to come back to it before that. If anyone would like to pick up from where I left off, feel free to do so. Cheers!

Loading

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Jun 25, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Loading

@k3a
Copy link

@k3a k3a commented Jun 25, 2019

/remove-lifecycle stale

Loading

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Sep 23, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Loading

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Oct 23, 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Loading

@redbaron
Copy link

@redbaron redbaron commented Oct 23, 2019

/remove-lifecycle rotten

Loading

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Jan 21, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Loading

@gkarthiks
Copy link
Member

@gkarthiks gkarthiks commented Jan 31, 2020

hi @filbranden Since we have a KEP process, can we please merge this soon or close this and create a KEP?

Loading

@gkarthiks
Copy link
Member

@gkarthiks gkarthiks commented Feb 4, 2020

note_to_myself: pinged Filipe.

Loading

@gkarthiks
Copy link
Member

@gkarthiks gkarthiks commented Feb 12, 2020

Hi @tallclair / @dchen1107 / @derekwaynecarr, referring you directly from the node-api owners' file.

Could you please review this PR and Merge / close. If this is still needed, can we move this to the KEP process?

Loading

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Mar 13, 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Loading

@redbaron
Copy link

@redbaron redbaron commented Mar 13, 2020

/remove-lifecycle rotten

Loading

@mrbobbytables
Copy link
Member

@mrbobbytables mrbobbytables commented Mar 13, 2020

I'm going to go ahead and close this out. Design proposals have been deprecated for over a year. For this to progress forward, please look into Kubernetes Enhancement Proposal Process.

/close

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 13, 2020

@mrbobbytables: Closed this PR.

In response to this:

I'm going to go ahead and close this out. Design proposals have been deprecated for over a year. For this to progress forward, please look into Kubernetes Enhancement Proposal Process.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants