New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of SIG CLI Charter #2453

Merged
merged 4 commits into from Aug 28, 2018

Conversation

@seans3
Contributor

seans3 commented Aug 2, 2018

Implements the initial governance rules for SIG CLI.

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker
Member

cblecker commented Aug 2, 2018

@kubernetes/steering-committee
/committee steering

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 9, 2018

Member

Hi @seans3 is this a redo of #2137? If so please close that one and point to here

Member

spiffxp commented Aug 9, 2018

Hi @seans3 is this a redo of #2137? If so please close that one and point to here

@philips

This comment has been minimized.

Show comment
Hide comment
@philips

philips Aug 10, 2018

Contributor

cc @bgrant0607 SIG CLI review

Contributor

philips commented Aug 10, 2018

cc @bgrant0607 SIG CLI review

Show outdated Hide outdated sig-cli/charter.md
Show outdated Hide outdated sig-cli/charter.md
Show outdated Hide outdated sigs.yaml
Show outdated Hide outdated sigs.yaml
Show outdated Hide outdated sig-cli/charter.md

seans3 added some commits Aug 17, 2018

Show outdated Hide outdated sig-cli/charter.md

@bgrant0607 bgrant0607 self-assigned this Aug 24, 2018

@bgrant0607

Thanks. Once my suggested changes are made I think this can be merged.

Show outdated Hide outdated sig-cli/charter.md
Show outdated Hide outdated sig-cli/charter.md
Show outdated Hide outdated sig-cli/charter.md
@philips

This comment has been minimized.

Show comment
Hide comment
@philips

philips Aug 27, 2018

Contributor

Since @pwittrock, @bgrant0607, and myself from the steering committee have all taken a look at this and #2137 I am going to approve this.

However, if @jbeda would like to take one final look as one of the designated Steering reviewers I will hold until EOD.

/lgtm
/approve
/hold

Contributor

philips commented Aug 27, 2018

Since @pwittrock, @bgrant0607, and myself from the steering committee have all taken a look at this and #2137 I am going to approve this.

However, if @jbeda would like to take one final look as one of the designated Steering reviewers I will hold until EOD.

/lgtm
/approve
/hold

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 27, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Aug 27, 2018

Member

/lgtm
from me too, FWIW

Member

spiffxp commented Aug 27, 2018

/lgtm
from me too, FWIW

@philips

This comment has been minimized.

Show comment
Hide comment
@philips

philips Aug 28, 2018

Contributor

/hold cancel

Contributor

philips commented Aug 28, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit ab4ada7 into kubernetes:master Aug 28, 2018

3 checks passed

cla/linuxfoundation seans3 authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@jdumars jdumars referenced this pull request Aug 31, 2018

Open

Charters Meta-issue #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment