Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark RuntimeClass as implementable #2489

Merged
merged 1 commit into from Oct 1, 2018

Conversation

@tallclair
Copy link
Member

tallclair commented Aug 7, 2018

For @kubernetes/sig-architecture-pr-reviews

/sig node
/sig architecture
/milestone v1.12
/priority important-soon
/kind design

@dchen1107

This comment has been minimized.

Copy link
Member

dchen1107 commented Sep 28, 2018

/lgtm

cc/ @derekwaynecarr

@dchen1107

This comment has been minimized.

Copy link
Member

dchen1107 commented Oct 1, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f70574f into kubernetes:master Oct 1, 2018

3 checks passed

cla/linuxfoundation tallclair authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

justaugustus pushed a commit to justaugustus/community that referenced this pull request Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.