Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community membership procedure #2521

Merged
merged 2 commits into from Aug 16, 2018

Conversation

@cblecker
Copy link
Member

cblecker commented Aug 11, 2018

This updates the community membership procedure, per the discussion #2510.

As this is a wider reaching change, it will need a lazy consensus window. I will probably open that up on Monday, and run it until Thursday.

/cc @kubernetes/owners @mistyhacks @spiffxp
/sig contributor-experience
/area github-management
fixes #2510

@idvoretskyi
Copy link
Member

idvoretskyi left a comment

/lgtm

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Aug 11, 2018

/hold

@spiffxp
Copy link
Member

spiffxp left a comment

Thanks for doing this. A few nits

@@ -41,58 +41,24 @@ Members are expected to remain active contributors to the community.
- Contributing to SIG, subproject, or community discussions (e.g. meetings, Slack, email discussion
forums, Stack Overflow)
- Subscribed to [kubernetes-dev@googlegroups.com]
- Have read the [developer guide]

This comment has been minimized.

@spiffxp

spiffxp Aug 13, 2018

Member

I think I would rather see us link to the Contributor's Guide instead. The devel directory is still a bit of a mess

- Body: List of contributions (PRs authored / reviewed, Issues responded to, etc)
- **[Open an issue](https://github.com/kubernetes/org/issues/new?template=membership.md&title=REQUEST%3A%20New%20membership%20for%20%3Cyour-GH-handle%3E) against the kubernetes/org repo**
- Ensure your sponsors are @mentioned on the issue
- Complete every item on the checklist (you can preview the current version of the template [here](https://git.k8s.io/org/.github/ISSUE_TEMPLATE/membership.md))

This comment has been minimized.

@spiffxp

spiffxp Aug 13, 2018

Member

Style nit: here links. Can we instead preview the current version of the template

but such is not the case currently. If you are a Kubernetes org member, you are implicitly eligible for
membership in related orgs, and can request membership when it becomes relevant, by sending an email to
*kubernetes-membership@googlegroups.com*, as outlined above.
There are related Kubernetes GitHub organizations, such as [kubernetes-sigs]. We are currently working on automation that would transfer membership in the Kubernetes organization to any related orgs automatically, but such is not the case currently. If you are a Kubernetes org member, you are implicitly eligible for membership in related orgs, and can request membership when it becomes relevant, by [opening an issue](https://github.com/kubernetes/org/issues/new?template=membership.md&title=REQUEST%3A%20New%20membership%20for%20%3Cyour-GH-handle%3E) against the kubernetes/org repo, as above.

This comment has been minimized.

@spiffxp

spiffxp Aug 13, 2018

Member

Let's link to the Actively used GitHub Organizations somehow, though I like explicitly calling out kubernetes-sigs as an example

@cblecker cblecker force-pushed the cblecker:membership-change branch from 707358e to bfda953 Aug 13, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 13, 2018

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Aug 13, 2018

@spiffxp comments addressed. PTAL

@mistyhacks

This comment has been minimized.

Copy link
Member

mistyhacks commented Aug 13, 2018

/cc @zacharysarah
/cc @jaredbhatti

- Body: Your GitHub handle
- Body: GitHub handles of sponsors
- Body: List of contributions (PRs authored / reviewed, Issues responded to, etc)
- **[Open an issue][membership request] against the kubernetes/org repo**

This comment has been minimized.

@mistyhacks

mistyhacks Aug 13, 2018

Member

Can you develop a specific, clickable URL that will pre-fill the important details of the issue and have that link in this doc? See https://eric.blog/2016/01/08/prefilling-github-issues/

This comment has been minimized.

@cblecker

cblecker Aug 13, 2018

Author Member

It already is! If you preview the document, you'll see it that it links to our issue template.

This comment has been minimized.

@spzala

spzala Aug 14, 2018

Member

@cblecker this is very nice and lgtm. Not for this PR but related couple of comments:

  1. In the Open an issue template, ### List of contributions to the Kubernetes project doesn't show full list in the Preview - Not sure if it's already been discussed/as designed/limitation but considering user most likely will look at preview, may miss noticing issue and sig related contributions, though I understand they are just examples and actual contributions can be more than shown in the list.
  2. In the same template for the issue title, wonder if <your-GH-handle> should use GitHub instead of GH.
    Thanks!

This comment has been minimized.

@nikhita

nikhita Aug 14, 2018

Member

In the Open an issue template, ### List of contributions to the Kubernetes project doesn't show full list in the Preview

@spzala created this today: kubernetes/org#11 :)

This comment has been minimized.

@spzala

spzala Aug 14, 2018

Member

@nikhita :) very nice. That takes care of it. Thanks!

but such is not the case currently. If you are a Kubernetes org member, you are implicitly eligible for
membership in related orgs, and can request membership when it becomes relevant, by sending an email to
*kubernetes-membership@googlegroups.com*, as outlined above.
There are related [Kubernetes GitHub organizations], such as [kubernetes-sigs]. We are currently working on automation that would transfer membership in the Kubernetes organization to any related orgs automatically, but such is not the case currently. If you are a Kubernetes org member, you are implicitly eligible for membership in related orgs, and can request membership when it becomes relevant, by [opening an issue][membership request] against the kubernetes/org repo, as above.

This comment has been minimized.

@mistyhacks

mistyhacks Aug 13, 2018

Member

Nit: line length

This comment has been minimized.

@cblecker

cblecker Aug 13, 2018

Author Member

The document was inconsistent with it's line wrapping. Just pushed a new commit to wrap all paragraphs at 80 chars.

[kubernetes-sigs]: https://github.com/kubernetes-sigs
[membership request]: https://github.com/kubernetes/org/issues/new?template=membership.md&title=REQUEST%3A%20New%20membership%20for%20%3Cyour-GH-handle%3E

This comment has been minimized.

@mistyhacks

mistyhacks Aug 13, 2018

Member

Ahh looks like you actually did include the link. Seems like maybe it belongs above instead of, or in addition, to here.

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Aug 13, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Aug 13, 2018

/lgtm
@nikhita 's github-contrib project is worth a mention here. It will generate a set of issues, PRs that the user has contributed! :)

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Aug 13, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Aug 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mistyhacks

This comment has been minimized.

Copy link
Member

mistyhacks commented Aug 13, 2018

/lgtm
Please file an issue in kubernetes/website to update https://kubernetes.io/docs/contribute/participating/#becoming-a-member after this is merged.

@cblecker cblecker referenced this pull request Aug 13, 2018

Closed

Update community membership procedure #9843

1 of 2 tasks complete
@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Aug 13, 2018

@mistyhacks done!

@jberkus

This comment has been minimized.

Copy link
Contributor

jberkus commented Aug 14, 2018

/lgtm

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Aug 16, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 1f31c94 into kubernetes:master Aug 16, 2018

3 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:membership-change branch Aug 16, 2018

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Aug 17, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.