New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new membership procedure doc #2736

Merged
merged 1 commit into from Oct 2, 2018

Conversation

@cblecker
Member

cblecker commented Oct 1, 2018

@idvoretskyi

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 1, 2018

@grodrigues3

other than this LGTM

@grodrigues3

This comment has been minimized.

Show comment
Hide comment
@grodrigues3

grodrigues3 Oct 1, 2018

Contributor

/lgtm

Contributor

grodrigues3 commented Oct 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 1, 2018

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 2, 2018

Member

/lgtm
This is fine for now, it doesn't mention adding existing members to other orgs, but I think we should clean up / add a new issue template for that, aka the "I'm already a member of X, there I want to be added Y" variety of requests

Member

spiffxp commented Oct 2, 2018

/lgtm
This is fine for now, it doesn't mention adding existing members to other orgs, but I think we should clean up / add a new issue template for that, aka the "I'm already a member of X, there I want to be added Y" variety of requests

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 2, 2018

Member

/approve
/hold
for @cblecker to /hold cancel

Member

spiffxp commented Oct 2, 2018

/approve
/hold
for @cblecker to /hold cancel

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 2, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 2, 2018

Member

Thanks all for reviews :)

/hold cancel

Member

cblecker commented Oct 2, 2018

Thanks all for reviews :)

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 261c810 into kubernetes:master Oct 2, 2018

3 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:new-membership branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment