New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wg-k8s-infra with draft charter #2830

Merged
merged 3 commits into from Jan 11, 2019

Conversation

@spiffxp
Copy link
Member

spiffxp commented Oct 19, 2018

There are some TODO's around renaming external assets from
k8s-infra-team to wg-k8s-infra, but I think that can be done
in a follow up PR. My main concern here is whether the
charter looks good enough to move forward

Listing as WIP while I see how this aligns with the current corpus of WG
docs from steering.

Fixes #2715

Content pulled from: https://docs.google.com/document/d/1zLh-YkLN3P09yyQf534VJCmiYUcqezh7HRHKyf7CenQ/edit

@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Oct 19, 2018

/sig testing
/sig contributor-experience
/sig architecture
/sig release
As the SIGs that I think this WG cuts across

/committee steering
To sanity check the WG stuff

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Oct 19, 2018

/cc

@k8s-ci-robot k8s-ci-robot requested a review from cblecker Oct 19, 2018

@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Oct 19, 2018

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Oct 22, 2018

/lgtm

@dims

This comment has been minimized.

Copy link
Member

dims commented Oct 22, 2018

Looks great! thanks @spiffxp

@thockin
Copy link
Member

thockin left a comment

LGTM overall.

Show resolved Hide resolved wg-k8s-infra/charter.md Outdated
@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Oct 22, 2018

/hold
mostly testing whether k8s-ci-robot is responding now

@spiffxp spiffxp changed the title [wip] Add wg-k8s-infra with draft charter Add wg-k8s-infra with draft charter Oct 22, 2018

@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Jan 10, 2019

Charter's been rebased, I squashed the previous commits. Now looking at changes necessary to address steering concerns

@spiffxp spiffxp force-pushed the spiffxp:wg-k8s-infra branch from d433916 to e8c64c0 Jan 10, 2019

@bgrant0607

This comment has been minimized.

Copy link
Member

bgrant0607 commented Jan 11, 2019

LGTM. Thanks for the changes, @spiffxp

@dims

This comment has been minimized.

Copy link
Member

dims commented Jan 11, 2019

LGTM @spiffxp

@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Jan 11, 2019

Sounds like this is ready for a proper /lgtm, I'll remove the /hold when I get one

@BenTheElder
Copy link
Member

BenTheElder left a comment

/lgtm

@idvoretskyi
Copy link
Member

idvoretskyi left a comment

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, idvoretskyi, jdumars, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cblecker,idvoretskyi,jdumars,spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Jan 11, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 6d7d04d into kubernetes:master Jan 11, 2019

3 checks passed

cla/linuxfoundation spiffxp authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@spiffxp spiffxp deleted the spiffxp:wg-k8s-infra branch Jan 12, 2019

@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Jan 16, 2019

/wg k8s-infra

@philips

This comment has been minimized.

Copy link
Contributor

philips commented Jan 16, 2019

LGTM

1 similar comment
@dims

This comment has been minimized.

Copy link
Member

dims commented Jan 16, 2019

LGTM

@pwittrock

This comment has been minimized.

Copy link
Member

pwittrock commented Jan 16, 2019

/lgtm

3 similar comments
@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Jan 16, 2019

/lgtm

@jbeda

This comment has been minimized.

Copy link
Contributor

jbeda commented Jan 16, 2019

/lgtm

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Jan 16, 2019

/lgtm

@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Jan 16, 2019

Context: https://groups.google.com/a/kubernetes.io/d/msg/steering/FC7bblZLZ_I/HxK1zo-OCwAJ

I forgot to get written LGTMs from steering committee and asked for them retroactively. There are now LGTMs from a simple majority of the steering committee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment