New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add k8s.io/cloud-provider-sample to SIG Cloud Provider subproject #3051

Merged
merged 1 commit into from Feb 7, 2019

Conversation

@andrewsykim
Copy link
Member

andrewsykim commented Dec 22, 2018

@cheftako
Copy link
Member

cheftako left a comment

/lgtm

@cheftako

This comment has been minimized.

Copy link
Member

cheftako commented Dec 26, 2018

/approve

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Jan 19, 2019

/assign @cblecker
for approval

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 20, 2019

/lgtm
/approve

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Feb 6, 2019

@cblecker ping for approval.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, cblecker, cheftako, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2717f63 into kubernetes:master Feb 7, 2019

3 checks passed

cla/linuxfoundation andrewsykim authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment