New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go versions in development.md #3066

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
4 participants
@rf232
Copy link
Contributor

rf232 commented Jan 4, 2019

Document the go version bump for 1.13

@@ -141,7 +141,8 @@ development environment, please [set one up](http://golang.org/doc/code.html).
| 1.8 | 1.8.3 |
| 1.9 | 1.9.1 |
| 1.10 | 1.9.1 |
| 1.11+ | 1.10.2 |
| 1.11, 1.12 | 1.10.2 |
| 1.13+ | 1.11.1 |

This comment has been minimized.

@rf232

rf232 Jan 4, 2019

Contributor

I based this on the minimum_go_version as updated in kubernetes/kubernetes#69386

(https://github.com/kubernetes/kubernetes/pull/69386/files#diff-dac3f0d616ae45f98d45d6420ed1be65L363 for the exact diff)

But if you think documenting the used go version is a better option, I can change it.

This comment has been minimized.

@cblecker

cblecker Jan 5, 2019

Member

let's go with recommended here as @nikhita suggests. Thanks for updating these docs -- it's appreciated! 🍰

This comment has been minimized.

@rf232

rf232 Jan 7, 2019

Contributor

done

@rf232 rf232 changed the title Update development.md Update Go versions in development.md Jan 7, 2019

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Jan 7, 2019

@rf232 Can you also squash the commits into a single commit? Will add lgtm after that. :)

@rf232 rf232 force-pushed the rf232:patch-2 branch from 74e60bc to 50cf95e Jan 7, 2019

Update go versions in development.md
Reflect used compiler versions in the list of go requirements for
building

@rf232 rf232 force-pushed the rf232:patch-2 branch from 50cf95e to 0e68686 Jan 7, 2019

@rf232

This comment has been minimized.

Copy link
Contributor

rf232 commented Jan 7, 2019

Squashed into one commit :)

@nikhita

nikhita approved these changes Jan 7, 2019

Copy link
Member

nikhita left a comment

Thank you! 🎉

/lgtm

/assign @cblecker
for approval

@k8s-ci-robot k8s-ci-robot assigned nikhita and cblecker and unassigned nikhita Jan 7, 2019

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 7, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nikhita, rf232

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2ae8821 into kubernetes:master Jan 7, 2019

3 checks passed

cla/linuxfoundation rf232 authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment