New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nikhita as contribex tech lead 馃帀馃巿猸愶笍 #3088

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@cblecker
Copy link
Member

cblecker commented Jan 11, 2019

@k8s-ci-robot k8s-ci-robot added the size/S label Jan 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor

fejta left a comment

Remove the gubernator changes?

However title has emoji in it so auto-
/lgtm

@fejta

This comment has been minimized.

Copy link
Contributor

fejta commented Jan 11, 2019

/hold

@@ -42,7 +42,7 @@ The following subprojects are owned by sig-testing:
- Owners:
- https://raw.githubusercontent.com/kubernetes/test-infra/master/gubernator/OWNERS
- **gubernator**
- Description: Gubernator is a frontend for displaying Kubernetes test results stored in GCS. See gubernator.k8s.io to see it in action for the Kubernetes project.

This comment has been minimized.

@cblecker

cblecker Jan 11, 2019

Member

@fejta the gubernator change is erroneous trailing whitespace that my editor auto-removed.

@dims

This comment has been minimized.

Copy link
Member

dims commented Jan 11, 2019

LGTM 馃憤

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 11, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 90f3ff4 into kubernetes:master Jan 11, 2019

3 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:NIKHITA branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment