New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code slush #3090

Merged
merged 2 commits into from Jan 15, 2019

Conversation

Projects
None yet
5 participants
@spiffxp
Copy link
Member

spiffxp commented Jan 12, 2019

We decided a clear warning to brace for code freeze was sufficient,
and a whole extra delineated phase wasn't worth the effort. We'll
still remind folks not to do mean things like land massive changes
or refactors N days before code freeze.

ref: kubernetes/sig-release#269

/kind documentation
/sig release
/cc @tpepper

Remove code slush
We decided a clear warning to brace for code freeze was sufficient,
and a whole extra delineated phase wasn't worth the effort. We'll
still remind folks not to do mean things like land massive changes
or refactors N days before code freeze.

ref: #269
@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Jan 12, 2019

/hold
for comment

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 12, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 12, 2019

Wholeheartedly support this change.

@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Jan 14, 2019

Definitely like the direction. Slush has been too ambiguous imho, and nobody really asks for clarification I think because it's just not really used as a thing. PR here generally looks good, though I note week 9 is now missing in the tldr table which has Weeks 1-8 -> Weeks 10-12. Should change 1-8 to instead be 1-9.

Update week numbers to match v1.14 release cycle
The post-holiday slump means this release cycle started
later than usual, so we only effectively have 12 weeks
instead of 13. I have adjusted the numbers accordingly

@k8s-ci-robot k8s-ci-robot added size/M and removed lgtm size/S labels Jan 15, 2019

@spiffxp

This comment has been minimized.

Copy link
Member Author

spiffxp commented Jan 15, 2019

@tpepper I adjusted the week numbers, please take a look and see the commit for details on why those numbers specifically

@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Jan 15, 2019

/lgtm

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 15, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 5a87546 into kubernetes:master Jan 15, 2019

3 checks passed

cla/linuxfoundation spiffxp authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@spiffxp spiffxp deleted the spiffxp:no-more-code-slush-only-ned-stark branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment