Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving files issue3097 #3112

Merged
merged 2 commits into from Jan 22, 2019
Merged

Conversation

eduartua
Copy link
Member

@eduartua eduartua commented Jan 18, 2019

Realted to #3097

Moving files that need to be updated and it is better they live in contributors/design-proposals/architecture.

/sig contributor-experience
/kind feature

/assign @nikhita @bgrant0607
/cc @parispittman

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. kind/feature Categorizes issue or PR as related to a new feature. kind/design Categorizes issue or PR as related to design. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 18, 2019
@eduartua
Copy link
Member Author

/assign @cblecker

@justaugustus
Copy link
Member

/cc

@nikhita
Copy link
Member

nikhita commented Jan 20, 2019

@eduartua After you address the comment, I'd suggest posting a link to the PR and asking @bgrant0607 to take a look, on the mailing list thread that you started on sig-architecture about this.

GitHub notifications are pretty moot for @bgrant0607 so he'll probably see this sooner on the mailing list. :)

@eduartua
Copy link
Member Author

Also, related to #3064

@cblecker
Copy link
Member

@eduartua Are you able to git mv these files instead, so we retain the git history on them?

You can also use this local function to always git mv things when you're in a git repo:

function mv() {
    if git rev-parse --git-dir >/dev/null 2>&1; then
        git mv "$@"
    else
        mv "$@"
    fi
}

@eduartua
Copy link
Member Author

@cblecker sure, thank you.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 22, 2019
@eduartua
Copy link
Member Author

@eduartua Are you able to git mv these files instead, so we retain the git history on them?

You can also use this local function to always git mv things when you're in a git repo:

function mv() {
    if git rev-parse --git-dir >/dev/null 2>&1; then
        git mv "$@"
    else
        mv "$@"
    fi
}

Done

@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, eduartua

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit d43d85d into kubernetes:master Jan 22, 2019
@eduartua eduartua deleted the moving-files-issue3097 branch January 23, 2019 22:15
@bgrant0607
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants