New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify the actual number of main types of groups #3182

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
4 participants
@tariq1890
Copy link
Member

tariq1890 commented Jan 31, 2019

As per Brian Grant in another thread #3174 (comment)

Yes, it is intended. They are subgroups of SIGs. Thanks.

Since subprojects (like cluster-api) are subsumed by actual SIGs like cluster-lifecyle, I think it should be 4 "main types of groups".

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 31, 2019

It's not a "top level" group, but it's important enough to be a "main" type of group IMO. I think this is unneeded.

@tariq1890

This comment has been minimized.

Copy link
Member Author

tariq1890 commented Jan 31, 2019

I understand the intent and message. Perhaps the whole thing can be worded and illustrated better. The indent and the definition of "main" does cause some confusion. But that might just be me.

@bgrant0607

This comment has been minimized.

Copy link
Member

bgrant0607 commented Feb 6, 2019

Please remove the number. "The project is comprised of the following types of subgroups:"

@tariq1890

This comment has been minimized.

Copy link
Member Author

tariq1890 commented Feb 6, 2019

@tariq1890 tariq1890 force-pushed the tariq1890:governance branch from f87d28a to 8d1b111 Feb 6, 2019

@tariq1890

This comment has been minimized.

Copy link
Member Author

tariq1890 commented Feb 6, 2019

@bgrant0607 Done!

Show resolved Hide resolved governance.md Outdated

@tariq1890 tariq1890 force-pushed the tariq1890:governance branch from 8d1b111 to 4091e1d Feb 6, 2019

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Feb 6, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1d8230a into kubernetes:master Feb 6, 2019

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation tariq1890 authorized
Details
pull-community-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment