New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in devel/sig-testing #3222

Merged
merged 1 commit into from Feb 6, 2019

Conversation

@mattjmcnaughton
Copy link
Contributor

mattjmcnaughton commented Feb 6, 2019

It looks like some links were not updated when devel/sig-testing was
created and populated with documentation.

Additionally, move gubernator-images to devel/sig-testing, as only
the gubernator.md file uses these images, and it now lives in
devel/sig-testing.

Fix broken links in devel/sig-testing
It looks like some links were not updated when `devel/sig-testing` was
created and populated with documentation.

Additionally, move `gubernator-images` to `devel/sig-testing`, as only
the `gubernator.md` file uses these images, and it now lives in
`devel/sig-testing`.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 6, 2019

Hi @mattjmcnaughton. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 6, 2019

@mattjmcnaughton: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

It looks like some links were not updated when devel/sig-testing was
created and populated with documentation.

Additionally, move gubernator-images to devel/sig-testing, as only
the gubernator.md file uses these images, and it now lives in
devel/sig-testing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor Author

mattjmcnaughton commented Feb 6, 2019

/assign @timothysc

Thanks!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 6, 2019

@mattjmcnaughton: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/assign @timothysc

Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Feb 6, 2019

/unassign @timothysc
/assign @eduartua

Assigning @eduartua for review.

/ok-to-test

@eduartua

This comment has been minimized.

Copy link
Contributor

eduartua commented Feb 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 6, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, mattjmcnaughton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c6ab1dd into kubernetes:master Feb 6, 2019

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation mattjmcnaughton authorized
Details
pull-community-verify Job succeeded.
Details

@mattjmcnaughton mattjmcnaughton deleted the mattjmcnaughton:mattjmcnaughton/fix-broken-links-in-sig-testing branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment