Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deduping gov docs + creating a lifecycle checklist #3287

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@parispittman
Copy link
Contributor

parispittman commented Feb 21, 2019

This addresses several related issues
(deduping, removing tactical/procedure from policy, formatting) that I won't completely tag here for purposes of not auto closing the issues. 1997, 2857

This needs many eyes. I tried to correct some content errors that I saw but please leave comments on stale processes, things that are duplicated still, etc.

TODO:

  • generator/list.tmpl -> need to change the sig creation link to sig-wg-lifecycle (doc added here)
  • fix all dependancies to the root /sig-goverance.md to direct to the /committee-steering/sig-governance file.

@parispittman parispittman self-assigned this Feb 21, 2019

@parispittman parispittman requested review from jbeda and spiffxp Feb 21, 2019

@k8s-ci-robot k8s-ci-robot requested a review from calebamiles Feb 21, 2019

@parispittman parispittman removed the request for review from calebamiles Feb 21, 2019

@parispittman parispittman force-pushed the parispittman:govdocs branch 2 times, most recently from 89c344d to f4a6999 Feb 21, 2019

@bgrant0607

This comment has been minimized.

Copy link
Member

bgrant0607 commented Feb 21, 2019

@@ -155,11 +168,15 @@ Issues impacting multiple subprojects in the SIG should be resolved by either:
- after 3 or more months it *SHOULD* be retired
- after 6 or more months it *MUST* be retired

[SIG PM]: https://github.com/kubernetes/community/tree/master/sig-pm
[k/features]: https://github.com/kubernetes/features

This comment has been minimized.

@ameukam

ameukam Feb 21, 2019

Contributor
Suggested change
[k/features]: https://github.com/kubernetes/features
[k/enhancements]: https://github.com/kubernetes/enhancements

This comment has been minimized.

@parispittman

parispittman Mar 5, 2019

Author Contributor

ty

@@ -97,10 +105,10 @@ field technical escalations, etc.
Example subprojects for a few SIGs:
* SIG Network: pod networking (CNI, etc.), Service (incl. kube-proxy),
Ingress, DNS, and Network policy
* SIG Apps: workload APIs, Helm, Kompose, ...
* SIG Apps: workload APIs, Kompose, ...

This comment has been minimized.

@bgrant0607

bgrant0607 Feb 21, 2019

Member

Please just remove SIG Apps as an example. The other examples are more clear

@@ -1,114 +1,3 @@
# SIG Governance
This document should be deleted once all dependancies have been dealt with. This document was merged with several but most notably sunsetted in favor of the work in the [committee-steering] folder.

This comment has been minimized.

@cblecker

cblecker Feb 21, 2019

Member
W0221 03:25:09.483] sig-governance.md:1:41: "dependancies" is a misspelling of "dependencies"
- Report activity in the weekly community meeting at least once every quarter
- Participate in release planning meetings and retrospectives, and burndown meetings, as needed
- Ensure related work happens in a project-owned github org and repository, with code and tests explicitly owned and supported by the SIG, including issue triage, PR reviews, test-failure response, bug fixes, etc.
- Use the [forums provided] as the primary means of working, communicating, and collaborating, as opposed to private emails and meetings

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

Should we add something about having a clearly defined group of deciders for sub projects?

This comment has been minimized.

@parispittman

parispittman Mar 6, 2019

Author Contributor

wouldn't hurt

@@ -91,6 +99,11 @@ Subproject Owner Role. (this different from a SIG or Organization Member).
- Contributing instructions defined in the SIG CONTRIBUTING.md

### Project Management
In addition, SIGs have the following responsibilities to SIG PM:

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

SIGs? Subprojects?

This comment has been minimized.

@parispittman

This comment has been minimized.

@pwittrock

pwittrock Mar 6, 2019

Member

Non-blocking comment

@@ -4,14 +4,14 @@
Working Groups provide a formal avenue for disparate groups to collaborate around a common problem, craft a balanced
position, and disband. Because they represent the interests of multiple groups, they are a vehicle for consensus
building. If code is developed as part of collaboration within the Working Group, that code will be housed in an
appropriate repository as described in the [repositories document][repodoc]. The merging of this code into the repository

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

This breaks this link. Would you fix it to be the proper form?

will be governed by the standard policies regarding submitting code to that repository (e.g. developed within one or
more Subprojects owned by SIGs).

Because a working group is an official part of the Kubernetes project it is subject to steering committee oversight
over its formation and disbanding.

[repodoc]: https://github.com/kubernetes/community/blob/master/github-management/kubernetes-repositories.md
The tactical checklist to creation and/or retirement is found in the [SIG / WG lifeycle] document.

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

This breaks the link

and the steering committee with a link to the PR. A member of the community admin team will place a /hold on it
until it has an LGTM from at least one chair from each of the stakeholder SIGs, and a simple majority of the steering
committee.
Once the above questions have been answered, complete the rest of the checklist in the [SIG / WG lifeycle] document

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

Link for [SIG / WG lifeycle] doesn't work


[SIG / WG lifeycle]

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

Must add the target of the link here.

@@ -83,6 +87,10 @@ community.
See [sig governance] for more details about current SIG operating
mechanics, such as mailing lists, meeting times, etc.

More information:
[SIG Governance Requirements]

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

These don't appear on separate lines which I think was the intent. Add bullets (e.g. *) or additional new-lines.

@@ -1,114 +1,3 @@
# SIG Governance
This document should be deleted once all dependancies have been dealt with. This document was merged with several but most notably sunsetted in favor of the work in the [committee-steering] folder.

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

This document was merged with several but most notably sunsetted in favor of the work

Awkward sentence.

Each one of these has a linked canonical source guideline from set up to moderation and your role and responsibilities for each. We are all responsible for enforcing our [code of conduct].
- [ ] Read [moderation.md] and understand your role in keeping our community safe
- [ ] Create your mailing lists - One for your members and another for your chairs/leads
- Either [GoogleGroups] OR [discuss.kubernetes.io]

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

discuss.kubernetes.io link doesn't work

- [ ] Subscribe to the kubernetes-sig-leads@googlegroups.com group
- [ ] Join the #chairs-and-techleads slack channel

...with the community as part of [sig-governance]

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

sig-governance link doesn't work


## Prerequisites for a WG
- [ ] Read [wg-governance.md]
- [ ] Send email to [kubernetes-dev@googlegroups.com] with some of the questions answered from wg-goverance.md and wait for community discourse; ask for SIG sponsorship

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

I don't think the '[' are required. It renders them.


## Prerequisites for a WG
- [ ] Read [wg-governance.md]
- [ ] Send email to [kubernetes-dev@googlegroups.com] with some of the questions answered from wg-goverance.md and wait for community discourse; ask for SIG sponsorship

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

Should we have a template for this so they are easy to spot. e.g. the Subject is WG-Creation-Request: WG Foo

- You’ll need:
- SIG Name
- Directory url
- mission statement

This comment has been minimized.

@pwittrock

pwittrock Feb 27, 2019

Member

nit: inconsistent capitalization

@parispittman parispittman force-pushed the parispittman:govdocs branch from 64df27b to 305444a Mar 6, 2019

@parispittman

This comment has been minimized.

Copy link
Contributor Author

parispittman commented Mar 6, 2019

@pwittrock PTAL


## Prerequisites for a WG
- [ ] Read [wg-governance.md]
- [ ] Send email to [kubernetes-dev@googlegroups.com] titled "WG-Creation-Request: WG Foo" with some of the questions answered from wg-goverance.md and wait for community discourse; ask for SIG sponsorship

This comment has been minimized.

@pwittrock

pwittrock Mar 6, 2019

Member

nit: should wg-governance.md be a link?

@pwittrock

This comment has been minimized.

Copy link
Member

pwittrock commented Mar 7, 2019

Overall this is a huge improvement. Thank you.

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: parispittman, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [parispittman,pwittrock]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bgrant0607

This comment has been minimized.

Copy link
Member

bgrant0607 commented Mar 7, 2019

Thanks much.
/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 5abdff9 into kubernetes:master Mar 7, 2019

3 checks passed

cla/linuxfoundation parispittman authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@nikhita nikhita referenced this pull request Mar 12, 2019

Merged

Fix links to sig creation/lifecycle doc #3403

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.