Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to SIG Cloud Provider Charter #3370

Merged

Conversation

@andrewsykim
Copy link
Member

commented Mar 6, 2019

As discussed in today's SIG Cloud Provider meeting, here's an update to the SIG Cloud Provider charter.

Motivations:

  • To be in line with the charter template set by the steering committee
  • Added specific call outs for subprojects in our SIG (pending SIG folding discussions)
  • Guide for prioritizing work as we start planning/grooming for v1.15

Timeboxing this to March 20th 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

/hold

@andrewsykim

This comment has been minimized.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@andrewsykim: GitHub didn't allow me to assign the following users: cantbewong, rtheis.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @aoxn @cantbewong @cheftako @d-nishi @dvonthenen @frapposelli @hogepodge @jagosan @justaugustus @justinsb @mcrute @rtheis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rtheis
Copy link

left a comment

Overall lgtm

- the [common interfaces](https://github.com/kubernetes/cloud-provider/blob/master/cloud.go) consumed by all cloud providers
- the [cloud-controller-manager](https://github.com/kubernetes/kubernetes/tree/master/cmd/cloud-controller-manager), which acts as the “out-of-tree” cloud provider component for clusters.
- core controllers (started by the cloud-controller-manager) that interact with cloud provider resources
- all [cloud provider repositories](https://github.com/kubernetes?utf8=%E2%9C%93&q=cloud-provider-&type=&language=) under the Kubernetes organization

This comment has been minimized.

Copy link
@rtheis

rtheis Mar 8, 2019

What aspects of a specific cloud provider's repository does this SIG claim ownership over?

This comment has been minimized.

Copy link
@cheftako

cheftako Mar 12, 2019

Member

This SIG has ownership of the kubernetes/cloud-provider-* repos.
The intent is to coordinate and provide guidance for changes which effect multiple cloud-providers, for the best interest of the Kubernetes projects.
As an example how/when/where should IP addresses be assigned from the cloud provider to a node.

This comment has been minimized.

Copy link
@andrewsykim

andrewsykim Mar 13, 2019

Author Member

Agreed with Walter. I think as a default the SIG should own the entire repo (delegating responsibility to subprojects) but I don't think this is a hard requirement, it may make sense for other SIGs to own subdirectories of the provider repos where it makes sense.

@frapposelli

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 8, 2019

@mcrute

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

/lgtm

* Proposals, once submitted, SHOULD be placed on the next full meeting agenda
* Decisions within the scope of individual subprojects should be made by lazy consensus by subproject owners, with fallback to majority vote by subproject owners; if a decision can’t be made, it should be escalated to the SIG Chairs
* Issues impacting multiple subprojects in the SIG should be resolved by consensus of the owners of the involved subprojects; if a decision can’t be made, it should be escalated to the SIG Chairs
This sig follows adheres to the Roles and Organization Management outlined in [sig-governance]

This comment has been minimized.

Copy link
@cheftako

cheftako Mar 12, 2019

Member

follows adheres?
This sig adheres to

This comment has been minimized.

Copy link
@andrewsykim

andrewsykim Mar 27, 2019

Author Member

looks like a typo in the SIG charter template, I'll try to follow-up to fix the typo in the template

@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

It's been 7 days past the review deadline for this charter. Going to assume folks in the SIG approve of the charter so far :)

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 479937c into kubernetes:master Mar 27, 2019

3 checks passed

cla/linuxfoundation andrewsykim authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.