Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community membership requirement #3564

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
@cblecker
Copy link
Member

cblecker commented Apr 8, 2019

If sig leaders are not community members, this prevents us from putting them in OWNERS files, assigning issues/PRs to them, and other common community administration tasks. Requiring folks to go through this process also ensures that leaders are established members of the community and have had their work reviewed/sponsored by others.

/committee steering
/cc @kubernetes/steering-committee
/hold

@k8s-ci-robot k8s-ci-robot requested a review from kubernetes/steering-committee Apr 8, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 8, 2019

/approve cancel
This needs to be reviewed and approved by the steering committee.

@k8s-ci-robot k8s-ci-robot removed the approved label Apr 8, 2019

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 8, 2019

+1 from me.

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Apr 8, 2019

+1

1 similar comment
@parispittman

This comment has been minimized.

Copy link
Contributor

parispittman commented Apr 8, 2019

+1

@bgrant0607

This comment has been minimized.

Copy link
Member

bgrant0607 commented Apr 8, 2019

Seems reasonable, and not too much to ask. The kubernetes org has almost 900 members already. +1

@philips

This comment has been minimized.

Copy link
Contributor

philips commented Apr 8, 2019

+1 /lgtm

@mrbobbytables

This comment has been minimized.

Copy link
Member

mrbobbytables commented Apr 9, 2019

Should this be applied to working group leads as well?

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 9, 2019

@mrbobbytables Perhaps, but working groups have a different place in our ecosystem. I could see it making sense for a sig to sponsor a working group organizer who is new to the community.

I personally don't feel strongly either way, but am happy to amend my PR if there are opinions supporting adding that requirement for other groups like working groups, committees, or user groups.

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Apr 10, 2019

I'll add my +1 as a steering member. And yes, I think this should apply to more than just SIGs:

  • SIG chairs and tech leads
  • UG chairs
  • WG organizers
  • Committee members

At a minimum, these folks need to be able to review and approve docs that describe what their group is and how it operates. Thus, must be org members.

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 10, 2019

@thecrudge

This comment has been minimized.

Copy link
Contributor

thecrudge commented Apr 12, 2019

Im brand spanking new, and this is just common sense. +1

@cblecker cblecker force-pushed the cblecker:sig-chairs branch 2 times, most recently from fd10b3a to 0a77705 Apr 12, 2019

@k8s-ci-robot k8s-ci-robot added size/M and removed size/XS labels Apr 12, 2019

@cblecker cblecker force-pushed the cblecker:sig-chairs branch from 0a77705 to 7362dfe Apr 12, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 12, 2019

/approve cancel

Based on @spiffxp's comments, I've added this requirement to other documentation to reflect it impacting sigs/wgs/ugs/committees.

@timothysc

This comment has been minimized.

Copy link
Member

timothysc commented Apr 12, 2019

+1 from me

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Apr 16, 2019

Looks like there is enough consensus around this and this looks good to go? :)

@dims

This comment has been minimized.

Copy link
Member

dims commented Apr 16, 2019

yes, please ship it

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 16, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit aef3f37 into kubernetes:master Apr 16, 2019

3 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:sig-chairs branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.