Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated developer documentation - upgrading Go #3571

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@alejandrox1
Copy link
Contributor

alejandrox1 commented Apr 10, 2019

Signed-off-by: Jorge Alarcon Ochoa alarcj137@gmail.com

@alejandrox1

This comment has been minimized.

Copy link
Contributor Author

alejandrox1 commented Apr 10, 2019

/assign @cblecker

@@ -150,9 +151,8 @@ images.

- The image for cross compiling in [build/build-image/cross].
The `VERSION` file and `Dockerfile`.
- Update the desired Go version in Dockerfile for the [e2e][e2e-image] and [test][test-image].
This requires pushing the [e2e][e2e-image] and [test][test-image] images that are `FROM` the desired Go version.

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 10, 2019

Member

The test image in test/images/Makefile needs to be updated too
https://github.com/kubernetes/kubernetes/pull/74632/files

This comment has been minimized.

Copy link
@alejandrox1

alejandrox1 Apr 10, 2019

Author Contributor

Thank you for the ctach @cblecker !
Fixed it

@alejandrox1 alejandrox1 force-pushed the alejandrox1:update-devel-docs branch from 3fb5063 to 8c6a0d3 Apr 10, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Apr 10, 2019

Updated developer documentation - upgrading Go
Signed-off-by: Jorge Alarcon Ochoa <alarcj137@gmail.com>

@alejandrox1 alejandrox1 force-pushed the alejandrox1:update-devel-docs branch from 8c6a0d3 to 160c9e9 Apr 10, 2019

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Apr 10, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a58691e into kubernetes:master Apr 10, 2019

2 of 3 checks passed

tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation alejandrox1 authorized
Details
pull-community-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.