Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some links #3683

Merged
merged 1 commit into from May 7, 2019

Conversation

@k-toyoda-pi
Copy link
Contributor

commented May 7, 2019

Some files have old links like https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md.

This PR changes that to new links.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

Hi @k-toyoda-pi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita

nikhita approved these changes May 7, 2019

Copy link
Member

left a comment

@k-toyoda-pi thank you :)

/ok-to-test
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, k-toyoda-pi, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 998763c into kubernetes:master May 7, 2019

4 checks passed

cla/linuxfoundation k-toyoda-pi authorized
Details
pull-community-tempelis-check Skipped.
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@k-toyoda-pi k-toyoda-pi deleted the k-toyoda-pi:fix_new_link branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.