Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert changes to UG Big Data resource names #3688

Merged

Conversation

@erikerlandson
Copy link
Contributor

commented May 7, 2019

This PR is to revert changes I made in #3666; the original placeholder names I used turned out to be the ones preferred by committee.

The sigs.yaml file altered in some way that prevented me from directly reverting the original PR.

@erikerlandson

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Awesome, thank you!
/lgtm

@erikerlandson

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

@erikerlandson: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liyinan926

This comment has been minimized.

Copy link
Member

commented May 7, 2019

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, erikerlandson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8746056 into kubernetes:master May 7, 2019

4 checks passed

cla/linuxfoundation erikerlandson authorized
Details
pull-community-tempelis-check Skipped.
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.