Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize contributing cheatsheet in Bahasa Indonesia. #3697

Merged

Conversation

@irvifa
Copy link
Contributor

commented May 9, 2019

This is an initial commit for contributor cheat sheet thus addressing kubernetes/website#13996

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

Welcome @irvifa!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@irvifa

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

/retest
/assign @girikuncoro

@irvifa

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

@k8s-ci-robot k8s-ci-robot requested a review from chenrui333 May 9, 2019

@chenrui333
Copy link
Member

left a comment

I dont understand the language, but I vote for the work!!

Many thanks!

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented May 10, 2019

@irvifa thank you for taking on the localization of the cheatsheet to Indonesian. Really appreciate your efforts :)

@irvifa

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

/assign @castrojo

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@irvifa would you mind squashing your commits down? Once that's done I'll lgtm 👍

Initialize contributing cheatsheet in Bahasa Indonesia.
Fix mispelling committe to committee.
Fix nitty gritty leftover english in code.

@irvifa irvifa force-pushed the irvifa:id/add-contributor-cheatsheet branch from b4457ed to f7e521a May 14, 2019

@irvifa

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@mrbobbytables Done, thanks for reminding me 🙂

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented May 14, 2019

Awesome! Thanks so much :)

/lgtm

@irvifa

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@mrbobbytables so i'll still need approve from the owners right?

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented May 14, 2019

Yup, one should hop in soon :)

@castrojo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

/approve

Thanks for this, we appreciate it!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo, chenrui333, irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c26e934 into kubernetes:master May 14, 2019

3 of 4 checks passed

tide Not mergeable. Needs approved label.
Details
cla/linuxfoundation irvifa authorized
Details
pull-community-tempelis-check Skipped.
pull-community-verify Job succeeded.
Details

@irvifa irvifa deleted the irvifa:id/add-contributor-cheatsheet branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.