Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar and Markdown fixes for api-conventions #3755

Merged
merged 1 commit into from Jun 2, 2019

Conversation

@jaypipes
Copy link
Contributor

commented May 31, 2019

When going through the api-conventions markdown doc online, I noticed a
couple small grammar and Markdown formatting issues. This patch fixes
those up.

Grammar and Markdown fixes for api-conventions
When going through the api-conventions markdown doc online, I noticed a
couple small grammar and Markdown formatting issues. This patch fixes
those up.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Welcome @jaypipes!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Hi @jaypipes. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

#### Strategic Merge Patch

Details of Strategic Merge Patch are covered [here](/contributors/devel/sig-api-machinery/strategic-merge-patch.md).
[here](/contributors/devel/sig-api-machinery/strategic-merge-patch.md).

This comment has been minimized.

Copy link
@jaypipes

jaypipes May 31, 2019

Author Contributor

Note to reviewers: I got rid of this section in the markdown document because the whole section was just a link to another doc describing the strategic merge patch and the bullet list entry directly above here contained virtually the exact phrase as what was contained in this section. So, I just condensed the whole section to be a link to the strategic merge patch document from the bulleted list entry above.

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

/ok-to-test
/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt Jun 2, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

/lgtm

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

/assign @dims
for approval

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c6d2155 into kubernetes:master Jun 2, 2019

4 checks passed

cla/linuxfoundation jaypipes authorized
Details
pull-community-tempelis-check Skipped.
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.