Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Chinese translation of contributor cheat sheet #3756

Merged

Conversation

@idealhack
Copy link
Member

commented Jun 1, 2019

fixes kubernetes/website#13990

this PR also added links for translations and cleaned up some links and typos

@idealhack

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

@idealhack idealhack force-pushed the idealhack:i18n/contributor-cheatsheet branch from ea27203 to 7fa580e Jun 1, 2019

@idealhack

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

@k8s-ci-robot k8s-ci-robot requested a review from zhangqx2010 Jun 1, 2019

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Thanks @idealhack \o/

@chenrui333

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Nice job. Will check out later.

@chenrui333
Copy link
Member

left a comment

lgtm except some minor comments. Good job. 👍

@idealhack idealhack force-pushed the idealhack:i18n/contributor-cheatsheet branch from 7fa580e to fb1a465 Jun 2, 2019

@idealhack

This comment has been minimized.

Copy link
Member Author

commented Jun 2, 2019

@chenrui333 thanks for your review, I think I've addressed all of them :)

@chenrui333
Copy link
Member

left a comment

/lgtm

Thanks for the change!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, chenrui333, idealhack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c4b1787 into kubernetes:master Jun 2, 2019

4 checks passed

cla/linuxfoundation idealhack authorized
Details
pull-community-tempelis-check Skipped.
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.