Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more event owners #3761

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@parispittman
Copy link
Contributor

commented Jun 3, 2019

adding folks who have been with us for 3+ contributor summits. need to discuss with others, too.

@nikhita

nikhita approved these changes Jun 3, 2019

Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 3, 2019

@guineveresaenger

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

gulp

Seems legit. I accept the responsibility.

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

/pony yes

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@mrbobbytables: pony image

In response to this:

/pony yes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guineveresaenger

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

/pony li'l-sebastian

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@guineveresaenger: Couldn't find a pony matching that query.

In response to this:

/pony li'l-sebastian

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

left a comment

+1

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nikhita, parispittman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tpepper

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 27f9536 into kubernetes:master Jun 4, 2019

3 of 4 checks passed

tide Not mergeable. Should not have do-not-merge/hold label.
Details
cla/linuxfoundation parispittman authorized
Details
pull-community-tempelis-check Skipped.
pull-community-verify Job succeeded.
Details

Contributor Experience automation moved this from In Progress to Completed Jun 4, 2019

@guineveresaenger

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Waiting on @tpepper and @jberkus to explicitly agree then we can remove the hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.